usb: phy: load usb phy earlier
This patch does not belong to phy, so, doesn't need to add phy in subject, meanwhile, please add GregKH as TO list, he is the right one to queue this patch.
Reply-To:
In-Reply-To: <1423554627-694-5-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Quoted 32 lines · Zhangfei Gao
Since phy is definitely used in usb controller, load the phy earlier to make boot time shorter.
Signed-off-by Zhangfei Gao <[email protected]>Acked-by Peter Chen <[email protected]>--- drivers/usb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/Makefile +1
-1@@ -5,6 +5,7 @@ # Object files in subdirectories obj-$(CONFIG_USB) += core/ +obj-$(CONFIG_USB_SUPPORT) += phy/ obj-$(CONFIG_USB_DWC3) += dwc3/ obj-$(CONFIG_USB_DWC2) += dwc2/@@ -48,7 +49,6 @@ obj-$(CONFIG_USB_MICROTEK) += image/ obj-$(CONFIG_USB_SERIAL) += serial/ obj-$(CONFIG_USB) += misc/ -obj-$(CONFIG_USB_SUPPORT) += phy/ obj-$(CONFIG_EARLY_PRINTK_DBGP) += early/ obj-$(CONFIG_USB_ATM) += atm/Signature · 1 line
1.9.1
Signature · 6 lines
Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v3 4/5 usb: phy: load usb phy earlier
Quoted 6 lines · Peter Chen
This patch does not belong to phy, so, doesn't need to add phy in subject, meanwhile, please add GregKH as TO list, he is the right one to queue this patch.
Reply-To:
In-Reply-To: <[email protected]>
OK, thanks Peter.
Will resend this patchset and drop this one.
Felipe Balbi
NAKPATCH v3 4/5 usb: phy: load usb phy earlier
In reply to Peter ChenQuoted 4 lines · Peter Chen
This patch does not belong to phy, so, doesn't need to add phy in subject, meanwhile, please add GregKH as TO list, he is the right one to queue this patch.
Quoted 9 lines
Reply-To:
In-Reply-To: <[email protected]>Quoted 5 lines · Zhangfei Gao
Since phy is definitely used in usb controller, load the phy earlier to make boot time shorter.
Signed-off-by Zhangfei Gao <[email protected]>Acked-by Peter Chen <[email protected]>
NAK, make sure there are no such dependencies with your controller driver. They should know how to defer probing if their resources aren't available yet.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150210/6c13a06b/attachment.sig>
PATCH v3 4/5 usb: phy: load usb phy earlier
Quoted 12 lines · Felipe Balbi
Quoted 11 lines · Peter Chen
This patch does not belong to phy, so, doesn't need to add phy in subject, meanwhile, please add GregKH as TO list, he is the right one to queue this patch.
Reply-To:
In-Reply-To: <[email protected]>Quoted 3 lines · Zhangfei Gao
Since phy is definitely used in usb controller, load the phy earlier to make boot time shorter.
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Zhangfei Gao <[email protected]>Acked-by Peter Chen <[email protected]>NAK, make sure there are no such dependencies with your controller driver. They should know how to defer probing if their resources aren't available yet.
Sorry for the confusion,
There is no dependencies at all, just for optimization.
Peter already told me this patch should not be put here, causing confusion. And I resend in another thread.
The controller is dwc2, which use defer probe. And dwc2 controller defer probe every time even the phy driver in the same folder. Since we know the calling sequence, we can simply change the sequence to load the phy earlier.
However, as you said the new driver will be put in drivers/phy, there should be no such issue in the future.
It is OK not using this patch.
Thanks
PATCH v3 4/5 usb: phy: load usb phy earlier
In reply to Felipe BalbiQuoted 10 lines · Peter Chen
Quoted 8 lines
This patch does not belong to phy, so, doesn't need to add phy in subject, meanwhile, please add GregKH as TO list, he is the right one to queue this patch.
Reply-To:
In-Reply-To: <[email protected]>On Tue, Feb 10, 2015 at 03:50:26PM +0800, Zhangfei Gao wrote:
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines
Since phy is definitely used in usb controller, load the phy earlier to make boot time shorter.
Signed-off-by Zhangfei Gao <[email protected]>Acked-by Peter Chen <[email protected]>NAK, make sure there are no such dependencies with your controller driver. They should know how to defer probing if their resources aren't available yet.
I NAKed it first.
But after thinking more, I think it is a good patch, USB PHY works proper is the base for coming USB controller operation, with this patch, it can avoid the controller drivers which are linked earlier than USB PHY always being probed deferral, look at drivers/Makefile, it links drivers follow the similar method.
Zhangfei, you may need to add more description in your commit log to prove it is a good improvement.
Peter