Skip to contentSkip to conversation

multi-layer support for overlay filesystem

GIT PULL Miklos Szeredi 2 participants 3 messages Feb 11, 2015 – Feb 19, 2015 VFS

lore
Share & tools
lore
#0 lore raw

Al,

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next

This adds support for multiple read-only layers to overlayfs. It also makes the writable upper layer optional.

This is a highly requested feature and has been in -next for the last cycle.

Thanks,
Miklos

---
Miklos Szeredi (16):
ovl: check whiteout while reading directory
ovl: make path-type a bitmap
ovl: dont replace opaque dir
ovl: add mutli-layer infrastructure
ovl: helper to iterate layers
ovl: multi-layer readdir
ovl: multi-layer lookup
ovl: check whiteout on lowest layer as well
ovl: lookup ENAMETOOLONG on lower means ENOENT
ovl: allow statfs if no upper layer
ovl: mount: change order of initialization
ovl: improve mount helpers
ovl: make upperdir optional
ovl: support multiple lower layers
ovl: add testsuite to docs
ovl: document lower layer ordering

Seunghun Lee (1):
ovl: Prevent rw remount when it should be ro mount

hujianyang (5):
ovl: Cleanup redundant blank lines
ovl: Use macros to present ovl_xattr
ovl: Fix kernel panic while mounting overlayfs
ovl: Fix opaque regression in ovl_lookup
ovl: discard independent cursor in readdir()

---
 Documentation/filesystems/overlayfs.txt |  28 ++
 fs/overlayfs/copy_up.c                  |   5 +-
 fs/overlayfs/dir.c                      |  28 +-
 fs/overlayfs/inode.c                    |  12 +-
 fs/overlayfs/overlayfs.h                |  18 +-
 fs/overlayfs/readdir.c                  | 181 +++++-----
 fs/overlayfs/super.c                    | 564 +++++++++++++++++++++-----------
 7 files changed, 517 insertions(+), 319 deletions(-)
#1 lore raw
Quoted 10 lines · Miklos Szeredi

Al,

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next

This adds support for multiple read-only layers to overlayfs. It also makes the writable upper layer optional.

This is a highly requested feature and has been in -next for the last cycle.

Ping.

Not sure whom I should send overlayfs pull requests to. Would direct to Linus be better?

Thanks,
Miklos

Quoted 38 lines

---
Miklos Szeredi (16):
ovl: check whiteout while reading directory
ovl: make path-type a bitmap
ovl: dont replace opaque dir
ovl: add mutli-layer infrastructure
ovl: helper to iterate layers
ovl: multi-layer readdir
ovl: multi-layer lookup
ovl: check whiteout on lowest layer as well
ovl: lookup ENAMETOOLONG on lower means ENOENT
ovl: allow statfs if no upper layer
ovl: mount: change order of initialization
ovl: improve mount helpers
ovl: make upperdir optional
ovl: support multiple lower layers
ovl: add testsuite to docs
ovl: document lower layer ordering

Seunghun Lee (1):
ovl: Prevent rw remount when it should be ro mount

hujianyang (5):
ovl: Cleanup redundant blank lines
ovl: Use macros to present ovl_xattr
ovl: Fix kernel panic while mounting overlayfs
ovl: Fix opaque regression in ovl_lookup
ovl: discard independent cursor in readdir()

---
 Documentation/filesystems/overlayfs.txt |  28 ++
 fs/overlayfs/copy_up.c                  |   5 +-
 fs/overlayfs/dir.c                      |  28 +-
 fs/overlayfs/inode.c                    |  12 +-
 fs/overlayfs/overlayfs.h                |  18 +-
 fs/overlayfs/readdir.c                  | 181 +++++-----
 fs/overlayfs/super.c                    | 564 +++++++++++++++++++++-----------
 7 files changed, 517 insertions(+), 319 deletions(-)
maintainer
#2 lore raw
Quoted 5 lines · Miklos Szeredi
Quoted 4 lines · Miklos Szeredi

Al,

Please pull from

Quoted 8 lines
Quoted 6 lines

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next

This adds support for multiple read-only layers to overlayfs. It also makes the writable upper layer optional.

This is a highly requested feature and has been in -next for the last cycle.

Ping.

Pong. I'm still looking through a large pile of assorted stuff, that pull request sitting in the queue. Should be done with that tomorrow (as in "pull or reply with last-minute-found $SOMETHING_DIRE"; FWIW, the last time I looked at multilayer stuff was a couple of weeks ago and nothing dire had been spotted, so the former is more likely).

ObSomethingDire^H^H^H^HOddElsewhere: what happens if libfuse fuse_lowlevel_notify_store() is called with SPLICE_F_MOVE in flags on an inode that happens to be mmaped with MAP_SHARED? Cache coherency isn't the main concern; I'm looking at

        /*
         * This is a new and locked page, it shouldn't be mapped or
         * have any special flags on it
         */
        if (WARN_ON(page_mapped(oldpage)))
                goto out_fallback_unlock;
        if (WARN_ON(page_has_private(oldpage)))
                goto out_fallback_unlock;
        if (WARN_ON(PageDirty(oldpage) || PageWriteback(oldpage)))
                goto out_fallback_unlock;
        if (WARN_ON(PageMlocked(oldpage)))
                goto out_fallback_unlock;

in fuse_try_move_page() and I don't see anything to prevent those WARN_ON getting triggered in that case. The call chain is fuse_try_move_page() <- fuse_copy_page() <- fuse_notify_store() <- fuse_notify() <- fuse_dev_do_write() <- fuse_dev_splice_write(), oldpage is obtained by
page = find_or_create_page(mapping, index,
mapping_gfp_mask(mapping));
in the loop in fuse_notify_store() and that ought to be able to pick the pages present in MAP_SHARED mappings...

What am I missing here? FWIW, I'd been trying to resurrect SPLICE_F_MOVE for local filesystems, and with FUSE being the only place in the kernel still trying to support it...