rtl2832: remove compiler warning
Subsystems (2)
PATCH v2 1/1 rtl2832: remove compiler warning
Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.
--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/rtl2832.c +1 -1
@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 uninitialized_var (tmp );dev_dbg (&client->dev,"\n" );
Signature · 1 line
2.1.3
Quoted 8 lines · Luis de Bethencourt
Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>
Antti
Quoted 18 lines
--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 uninitialized_var (tmp );dev_dbg (&client->dev,"\n" );
Signature · 1 line
http://palosaari.fi/
Quoted 28 lines · Luis de Bethencourt
Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this functionEven though it could never happen since if
rtl2832_rd_demod_reg() doesn't set tmp, this line would never run because we go to err. It is still nice to avoid compiler warnings.Signed-off-by Luis de Bethencourt <[email protected]>--- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/rtl2832.c +1
-1@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)struct rtl2832_dev *dev = fe->demodulator_priv;struct i2c_client *client = dev->client;int ret; -u32 tmp; +u32 uninitialized_var (tmp );dev_dbg (&client->dev,"\n" );Signature · 1 line
2.1.3
Hi Mauro,
The warning is still happening. Just a reminder in case you want to apply this patch.
Thanks,
Luis