lib/kstrtox.c Stop parsing integer on overflow
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 27 lines · Andrew Morton
?
Begin forwarded message:
Date: Mon, 16 Feb 2015 10:48:50 -0800
From: Anshul Garg <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: [PATCH]lib/kstrtox.cStop parsing integer on overflowFrom: Anshul Garg <[email protected]>
While converting string representation to integer
break the loop if overflow is detected.Signed-off-by Anshul Garg <[email protected]>--- lib/kstrtox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)lib/kstrtox.c +0
-0@@ -70,8 +70,10 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long* it in the max base we support (16)
lib/kstrtox.c unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long · line 79
Quoted 10 lines
lib/kstrtox.c +3
-1*/ if (unlikely (res & (~0ull <<60 ))) { -if (res >div_u64 (ULLONG_MAX - val, base)) +if (res >div_u64 (ULLONG_MAX - val, base)) { overflow =1 ; +break ; + } } res = res * base + val; rv++;
The _notion_ of a patch is OK if you want EVERY simple_strtoull() call to stop parsing past overflow right now. It SHOULD have done so from day 1, but it doesn't do that.
When I wrote kstrto*() code I deliberatedly didn't break this bug because of the sheer number of call sites.
If you are OK with changing bug-for-bug compatibility, then patch simply need to delete overflow detection code.
Alexey
Quoted 43 lines · Alexey Dobriyan
Quoted 27 lines · Andrew Morton
?
Begin forwarded message:
Date: Mon, 16 Feb 2015 10:48:50 -0800
From: Anshul Garg <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: [PATCH]lib/kstrtox.cStop parsing integer on overflowFrom: Anshul Garg <[email protected]>
While converting string representation to integer
break the loop if overflow is detected.Signed-off-by Anshul Garg <[email protected]>--- lib/kstrtox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)lib/kstrtox.c +0
-0@@ -70,8 +70,10 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long* it in the max base we support (16) lib/kstrtox.c unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long · line 79
Quoted 10 lines
lib/kstrtox.c +3
-1*/ if (unlikely (res & (~0ull <<60 ))) { -if (res >div_u64 (ULLONG_MAX - val, base)) +if (res >div_u64 (ULLONG_MAX - val, base)) { overflow =1 ; +break ; + } } res = res * base + val; rv++;The _notion_ of a patch is OK if you want EVERY
simple_strtoull()call to stop parsing past overflow right now. It SHOULD have done so from day 1, but it doesn't do that.
Quoted 7 lines
When I wrote kstrto*() code I deliberatedly didn't break this bug because of the sheer number of call sites.
If you are OK with changing bug-for-bug compatibility, then patch simply need to delete overflow detection code.
Alexey
I think this patch won't break any existing module using this function. because this function sets KSTRTOX_OVERFLOW as error status.
which is checked by calling function to determine whether value is correct or not.
If this flag is set we can simply discard the parsed value.
Quoted 52 lines · Anshul Garg
Quoted 43 lines · Alexey Dobriyan
Quoted 27 lines · Andrew Morton
?
Begin forwarded message:
Date: Mon, 16 Feb 2015 10:48:50 -0800
From: Anshul Garg <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: [PATCH]lib/kstrtox.cStop parsing integer on overflowFrom: Anshul Garg <[email protected]>
While converting string representation to integer
break the loop if overflow is detected.Signed-off-by Anshul Garg <[email protected]>--- lib/kstrtox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)lib/kstrtox.c +0
-0@@ -70,8 +70,10 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long* it in the max base we support (16) lib/kstrtox.c unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long · line 79
Quoted 10 lines
lib/kstrtox.c +3
-1*/ if (unlikely (res & (~0ull <<60 ))) { -if (res >div_u64 (ULLONG_MAX - val, base)) +if (res >div_u64 (ULLONG_MAX - val, base)) { overflow =1 ; +break ; + } } res = res * base + val; rv++;The _notion_ of a patch is OK if you want EVERY
simple_strtoull()call to stop parsing past overflow right now. It SHOULD have done so from day 1, but it doesn't do that.Quoted 7 lines
When I wrote kstrto*() code I deliberatedly didn't break this bug because of the sheer number of call sites.
If you are OK with changing bug-for-bug compatibility, then patch simply need to delete overflow detection code.
Alexey
Quoted 7 lines
I think this patch won't break any existing module using this function. because this function sets
KSTRTOX_OVERFLOWas error status.which is checked by calling function to determine whether value is correct or not.
If this flag is set we can simply discard the parsed value.
Which is my previous email is all about.
If you discard, every single simple_strto*() call will change its behaviour. If you're OK with that, patch is incomplete.
Alexey