Skip to contentSkip to conversation

Staging: media: Remove unneeded log macro

PATCH In review Vatika Harlalka 2 participants 2 messages Feb 19, 2015 – Feb 20, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: media: Remove unneeded log macro

This patch is to remove unneeded log macros which only indicate entry/exit from a function. The kernel provides mechanisms for function tracing so these can be dropped.

---
 drivers/staging/media/tlg2300/pd-main.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/media/tlg2300/pd-main.c +0 -2
index b31f479..c2dd3b4 100644
@@ -207,7 +207,6 @@ void poseidon_delete(struct kref *kref)
 		pd->interface = NULL;
 	}
 	kfree(pd);
-	log();
 }
 
 static int firmware_download(struct usb_device *udev)
@@ -538,7 +537,6 @@ static int __init poseidon_init(void)
 
 static void __exit poseidon_exit(void)
 {
-	log();
 	unregister_pm_notifier(&pm_notifer);
 	usb_deregister(&poseidon_driver);
 }
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · On Friday 20 February 2015 04:04:12 Vatika Harlalka wrote:

This patch is to remove unneeded log macros which only indicate entry/exit from a function. The kernel provides mechanisms for function tracing so these can be dropped.

I believe this driver was removed already, so the patch no longer applies.

drivers/staging/media/tlg2300/pd-main.c void poseidon_delete(struct kref *kref) · line 212

Quoted 13 lines
drivers/staging/media/tlg2300/pd-main.c +0 -1
index b31f479..c2dd3b4 100644
@@ -207,7 +207,6 @@ void poseidon_delete(struct kref *kref)
                pd->interface = NULL;
        }
        kfree(pd);
-       log();
 }
 
 static int firmware_download(struct usb_device *udev)

Doing this is a good idea in general, but if I did this for another driver, I would remove the macro definition along with the uses.

Arnd