memstick: mspro_block: add missing curly braces

PATCH New Dan Carpenter 1 participant 1 message Feb 25, 2015

Subsystems (2)

Kernel janitors Sony memorystick

lore

Share & tools

lore

Dan Carpenter

author

2015-02-25 13:15 UTC #0 lore raw

PATCH 1/1 memstick: mspro_block: add missing curly braces

From the indenting we can see the curly braces were obviously intended. This is a static checker fix, but my guess is that we don't read enough bytes, because we don't calculate "t_len" correctly.

Fixes f1d82698029b ('memstick: use fully asynchronous request processing')

Signed-off-by Dan Carpenter <[email protected]>

drivers/memstick/core/mspro_block.c +2 -1

index fc145d2..922a750 100644
@@ -758,7 +758,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
 
 		if (error || (card->current_mrq.tpc = MSPRO_CMD_STOP)) {
 			if (msb->data_dir = READ) {
-				for (cnt = 0; cnt < msb->current_seg; cnt++)
+				for (cnt = 0; cnt < msb->current_seg; cnt++) {
 					t_len += msb->req_sg[cnt].length
 						 / msb->page_size;

@@ -766,6 +766,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
 						t_len += msb->current_page - 1;
 
 					t_len *= msb->page_size;
+				}
 			}
 		} else
 			t_len = blk_rq_bytes(msb->block_req);