drm/i915: cleanup some indenting
Subsystems (3)
PATCH 1/1 drm/i915: cleanup some indenting
Static checkers complain that we should probably add curly braces because, from the indenting, it looks like seq_printf() should be inside the list_for_each_entry() loop. But the code is actually correct, it's just the indenting which is off.
Besides fixing the indenting on seq_printf(), I did add curly braces, because generally mult-line indents should have curly braces to make them more readable.
drivers/gpu/drm/i915/i915_debugfs.c +3 -2
@@ -139,10 +139,11 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) obj->madv == I915_MADV_DONTNEED ? " purgeable" : "");if (obj->base.name)seq_printf (m," (name: %d)" , obj->base.name); -list_for_each_entry (vma, &obj->vma_list, vma_link) +list_for_each_entry (vma, &obj->vma_list, vma_link) {if (vma->pin_count >0 ) pin_count++; -seq_printf (m," (pinned x %d)" , pin_count); + } +seq_printf (m," (pinned x %d)" , pin_count);if (obj->pin_display)seq_printf (m," (display)" );if (obj->fence_reg !=I915_FENCE_REG_NONE )
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Dan Carpenter
Static checkers complain that we should probably add curly braces because, from the indenting, it looks like
seq_printf()should be inside thelist_for_each_entry()loop. But the code is actually correct, it's just the indenting which is off.Besides fixing the indenting on
seq_printf(), I did add curly braces, because generally mult-line indents should have curly braces to make them more readable.Signed-off-by Dan Carpenter <[email protected]>
The unintended indent was left behind and not unindented in
commit d7f46fc4e7323887494db13f063a8e59861fefb0
Author: Ben Widawsky <[email protected]> Date: Fri Dec 6 14:10:55 2013 -0800
drm/i915: Make pin count per VMA
Quoted 18 lines
drivers/gpu/drm/i915/i915_debugfs.c +3
-2@@ -139,10 +139,11 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) obj->madv == I915_MADV_DONTNEED ? " purgeable" : "");if (obj->base.name)seq_printf (m," (name: %d)" , obj->base.name); -list_for_each_entry (vma, &obj->vma_list, vma_link) +list_for_each_entry (vma, &obj->vma_list, vma_link) {if (vma->pin_count >0 ) pin_count++; -seq_printf (m," (pinned x %d)" , pin_count); + } +seq_printf (m," (pinned x %d)" , pin_count);if (obj->pin_display)seq_printf (m," (display)" );if (obj->fence_reg !=I915_FENCE_REG_NONE )
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 12 lines · Jani Nikula
Quoted 10 lines · Dan Carpenter
Static checkers complain that we should probably add curly braces because, from the indenting, it looks like
seq_printf()should be inside thelist_for_each_entry()loop. But the code is actually correct, it's just the indenting which is off.Besides fixing the indenting on
seq_printf(), I did add curly braces, because generally mult-line indents should have curly braces to make them more readable.Signed-off-by Dan Carpenter <[email protected]>
Quoted 7 lines
The unintended indent was left behind and not unindented in
commit
d7f46fc4e7323887494db13f063a8e59861fefb0Author: Ben Widawsky <[email protected]> Date: Fri Dec 6 14:10:55 2013 -0800drm/i915: Make pin count per VMA
Added to the commit message.
Quoted 2 lines
Reviewed-by Jani Nikula <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel