Skip to contentSkip to conversation

tcm_fc: missing curly braces in ft_invl_hw_context()

PATCH In review Dan Carpenter 2 participants 2 messages Feb 25, 2015 – Feb 27, 2015

Subsystems (3)
SCSI Kernel janitors SCSI target
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 tcm_fc: missing curly braces in ft_invl_hw_context()

From the indenting, it looks like curly braces were intended here.

Fixes dcd998ccdbf7 ('tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data')
Signed-off-by Dan Carpenter <[email protected]>
drivers/target/tcm_fc/tfc_io.c +2 -1
index 97b486c..583e755 100644
@@ -359,7 +359,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
 		ep = fc_seq_exch(seq);
 		if (ep) {
 			lport = ep->lp;
-			if (lport && (ep->xid <= lport->lro_xid))
+			if (lport && (ep->xid <= lport->lro_xid)) {
 				/*
 				 * "ddp_done" trigger invalidation of HW
 				 * specific DDP context

@@ -374,6 +374,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
 				 * identified using ep->xid)
 				 */
 				cmd->was_ddp_setup = 0;
+			}
 		}
 	}
 }
#1 lore raw
Quoted 19 lines · Dan Carpenter

From the indenting, it looks like curly braces were intended here.

Fixes dcd998ccdbf7 ('tcm_fc: Handle DDP/SW fc_frame_payload_get failures in ft_recv_write_data')
Signed-off-by Dan Carpenter <[email protected]>
drivers/target/tcm_fc/tfc_io.c +1 -1
index 97b486c..583e755 100644
@@ -359,7 +359,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
 		ep = fc_seq_exch(seq);
 		if (ep) {
 			lport = ep->lp;
-			if (lport && (ep->xid <= lport->lro_xid))
+			if (lport && (ep->xid <= lport->lro_xid)) {
 				/*
 				 * "ddp_done" trigger invalidation of HW
 				 * specific DDP context

drivers/target/tcm_fc/tfc_io.c void ft_invl_hw_context(struct ft_cmd *cmd) · line 380

Quoted 7 lines
drivers/target/tcm_fc/tfc_io.c +1 -0
@@ -374,6 +374,7 @@ void ft_invl_hw_context(struct ft_cmd *cmd)
 				 * identified using ep->xid)
 				 */
 				cmd->was_ddp_setup = 0;
+			}
 		}
 	}
 }

Thanks Dan. Applied to target-pending/master.

--nab