lpfc: missing curly brace in lpfc_online()

PATCH New Dan Carpenter 1 participant 1 message Feb 25, 2015

Subsystems (3)

SCSI Kernel janitors Emulex/Broadcom lpfc FC/FCoE SCSI driver

lore

Share & tools

lore

Dan Carpenter

author

2015-02-25 13:24 UTC #0 lore raw

PATCH 1/1 lpfc: missing curly brace in lpfc_online()

This is harmless because we do the same thing either way but, from the indenting, then it seems like lpfc_destroy_vport_work_array() was meant to be inside the if statement.

Signed-off-by Dan Carpenter <[email protected]>

---
The static checker complains about some of the other indents as well.

drivers/scsi/lpfc/lpfc_init.c:708 lpfc_hba_init_link_fc_topology() warn: bad indenting. drivers/scsi/lpfc/lpfc_init.c:1978 lpfc_parse_vpd() warn: bad indenting. drivers/scsi/lpfc/lpfc_init.c:8116 lpfc_sli4_pci_mem_setup() warn: bad indenting.

drivers/scsi/lpfc/lpfc_init.c +2 -1

index 0b2c53a..f8fd364 100644
@@ -2822,7 +2822,7 @@ lpfc_online(struct lpfc_hba *phba)
 	}
 
 	vports = lpfc_create_vport_work_array(phba);
-	if (vports != NULL)
+	if (vports != NULL) {
 		for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
 			struct Scsi_Host *shost;
 			shost = lpfc_shost_from_vport(vports[i]);

@@ -2840,6 +2840,7 @@ lpfc_online(struct lpfc_hba *phba)
 			spin_unlock_irq(shost->host_lock);
 		}
 		lpfc_destroy_vport_work_array(phba, vports);
+	}
 
 	lpfc_unblock_mgmt_io(phba);
 	return 0;