Skip to contentSkip to conversation

rtlwifi: rtl8188ee: missing curly braces in handle_branch1()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 25, 2015 – Mar 3, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtlwifi: rtl8188ee: missing curly braces in handle_branch1()

From the indenting, it seems like the READ_NEXT_PAIR() was supposed to be inside the while loop.

drivers/net/wireless/rtlwifi/rtl8188ee/phy.c +2 -1
index 3f6c59c..a2bb02c 100644
@@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
 				READ_NEXT_PAIR(v1, v2, i);
 				while (v2 != 0xDEAD &&
 				       v2 != 0xCDEF &&
-				       v2 != 0xCDCD && i < arraylen - 2)
+				       v2 != 0xCDCD && i < arraylen - 2) {
 					_rtl8188e_config_bb_reg(hw, v1, v2);
 					READ_NEXT_PAIR(v1, v2, i);
+				}
 
 				while (v2 != 0xDEAD && i < arraylen - 2)
 					READ_NEXT_PAIR(v1, v2, i);
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter
Quoted 1 line

From the indenting, it seems like the READ_NEXT_PAIR() was supposed to

be inside the while loop.

Good catch.

Thanks,

Larry

Quoted 18 lines
drivers/net/wireless/rtlwifi/rtl8188ee/phy.c +2 -1
index 3f6c59c..a2bb02c 100644
@@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
  				READ_NEXT_PAIR(v1, v2, i);
  				while (v2 != 0xDEAD &&
  				       v2 != 0xCDEF &&
-				       v2 != 0xCDCD && i < arraylen - 2)
+				       v2 != 0xCDCD && i < arraylen - 2) {
  					_rtl8188e_config_bb_reg(hw, v1, v2);
  					READ_NEXT_PAIR(v1, v2, i);
+				}
 
  				while (v2 != 0xDEAD && i < arraylen - 2)
  					READ_NEXT_PAIR(v1, v2, i);