Skip to contentSkip to conversation

net: bcmgenet: add main driver file

DISCUSSION Dan Carpenter 1 participant 1 message Feb 25, 2015 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Florian Fainelli,

The patch 1c1008c793fa: "net: bcmgenet: add main driver file" from Feb 13, 2014, leads to the following static checker warning:

	drivers/net/ethernet/broadcom/genet/bcmgenet.c:1955 bcmgenet_init_dma()
	error: potential null dereference 'priv->tx_cbs'.  (kcalloc returns null)

drivers/net/ethernet/broadcom/genet/bcmgenet.c
1952 priv->tx_cbs = kcalloc(priv->num_tx_bds, sizeof(struct enet_cb),
1953 GFP_KERNEL);
1954 if (!priv->tx_cbs) {

  1955                  bcmgenet_fini_dma(priv);
                        ^^^^^^^^^^^^^^^^^^^^^^^

We dereference "priv->tx_cbs" inside the bcmgenet_fini_dma() function.

1956 return -ENOMEM;
1957 }

regards,
dan carpenter