NFS: fix clp->cl_revoked list deletion causing softlock in nfsd
Subsystems (2)
Thanks, applying for 3.20.
--b.
Quoted 29 lines
commit
2d4a532d385f("nfsd: ensure thatclp->cl_revokedlist is protected byclp->cl_lock") removed the use of the reaplist to clean outclp->cl_revoked. It failed to changelist_entry()to walkclp->cl_revoked.nextinstead of reaplist.nextFixes 2d4a532d385f ("nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock")Reported-by Eric Meddaugh <[email protected]>Tested-by Eric Meddaugh <[email protected]>Signed-off-by Andrew Elble <[email protected]>--- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfsd/nfs4state.c +1
-1@@ -1638,7 +1638,7 @@ __destroy_client(struct nfs4_client *clp)nfs4_put_stid (&dp->dl_stid); }while (!list_empty (&clp->cl_revoked)) { - dp = list_entry(reaplist.next, struct nfs4_delegation, dl_recall_lru); + dp = list_entry(clp->cl_revoked.next, struct nfs4_delegation, dl_recall_lru);list_del_init (&dp->dl_recall_lru);nfs4_put_stid (&dp->dl_stid); }Signature · 1 line
2.2.1