Skip to contentSkip to conversation

m68k: remove a superflous KERN_ERR

PATCH In review Dan Carpenter 2 participants 2 messages Mar 5, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: remove a superflous KERN_ERR

pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.

arch/m68k/kernel/pcibios.c +1 -1
index 931a31f..8520250 100644
@@ -62,7 +62,7 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
 
 		r = dev->resource + idx;
 		if (!r->start && r->end) {
-			pr_err(KERN_ERR "PCI: Device %s not available because of resource collisions\n",
+			pr_err("PCI: Device %s not available because of resource collisions\n",
 				pci_name(dev));
 			return -EINVAL;
 		}
#1 lore raw
Quoted 3 lines · Dan Carpenter

pr_err() has a KERN_ERR built in. Smatch complains about these nowadays.

Thanks! Will apply and queue for v4.1.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds