Skip to contentSkip to conversation

serial:8250:8250_pci: delete unneeded quirk entries

PATCH In review Wang YanQing 3 participants 3 messages Mar 6, 2015 – Mar 9, 2015 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial:8250:8250_pci: delete unneeded quirk entries

These quirk entries have the same effect as default quirk entry, so we can just delete them.

---
 drivers/tty/serial/8250/8250_pci.c | 14 --------------
 1 file changed, 14 deletions(-)
drivers/tty/serial/8250/8250_pci.c +0 -14
index daf2c82..cf1cab1 100644
@@ -1989,13 +1989,6 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
 	},
 	{
 		.vendor		= PCI_VENDOR_ID_INTEL,
-		.device		= PCI_DEVICE_ID_INTEL_QRK_UART,
-		.subvendor	= PCI_ANY_ID,
-		.subdevice	= PCI_ANY_ID,
-		.setup		= pci_default_setup,
-	},
-	{
-		.vendor		= PCI_VENDOR_ID_INTEL,
 		.device		= PCI_DEVICE_ID_INTEL_BSW_UART1,
 		.subvendor	= PCI_ANY_ID,
 		.subdevice	= PCI_ANY_ID,
@@ -2201,13 +2194,6 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
 	 */
 	{
 		.vendor		= PCI_VENDOR_ID_PLX,
-		.device		= PCI_DEVICE_ID_PLX_9030,
-		.subvendor	= PCI_SUBVENDOR_ID_PERLE,
-		.subdevice	= PCI_ANY_ID,
-		.setup		= pci_default_setup,
-	},
-	{
-		.vendor		= PCI_VENDOR_ID_PLX,
 		.device		= PCI_DEVICE_ID_PLX_9050,
 		.subvendor	= PCI_SUBVENDOR_ID_EXSYS,
 		.subdevice	= PCI_SUBDEVICE_ID_EXSYS_4055,
Signature · 1 line
2.2.2.dirty
#2 lore raw
Quoted 11 lines · Bryan O'Donoghue
Quoted 5 lines · Wang YanQing

These quirk entries have the same effect as default quirk entry, so we can just delete them.

ACK - does exactly what it says on the tin.

Guys, the idea was as far as I remember to keep this placeholder to introduce DMA support later.
Now it brought an additional effort to be done for that.

Signature · 2 lines
With Best Regards,
Andy Shevchenko