Skip to contentSkip to conversation

ASoC: cx20442: remove incorerct __exit markups

PATCH New Dmitry Torokhov 1 participant 1 message Mar 9, 2015

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 ASoC: cx20442: remove incorerct __exit markups

Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 sound/soc/codecs/cx20442.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/cx20442.c +2 -2
index 0b10979..0f334bc 100644
@@ -420,7 +420,7 @@ static int cx20442_platform_probe(struct platform_device *pdev)
 			&cx20442_codec_dev, &cx20442_dai, 1);
 }
 
-static int __exit cx20442_platform_remove(struct platform_device *pdev)
+static int cx20442_platform_remove(struct platform_device *pdev)
 {
 	snd_soc_unregister_codec(&pdev->dev);
 	return 0;

@@ -431,7 +431,7 @@ static struct platform_driver cx20442_platform_driver = {
 		.name = "cx20442-codec",
 		},
 	.probe = cx20442_platform_probe,
-	.remove = __exit_p(cx20442_platform_remove),
+	.remove = cx20442_platform_remove,
 };
 
 module_platform_driver(cx20442_platform_driver);
Signature · 5 lines
2.2.0.rc0.207.ga3a616c


-- 
Dmitry