Staging: rtl8192e: Remove unnecessary macro
PATCH 1/1 Staging: rtl8192e: Remove unnecessary macro
This patch removes the RTLLIB_PRINT_STR macro definition because it is olny defined in the header and it is never referenced.
Signed-off-by Cristina Opriceana <[email protected]>
--- drivers/staging/rtl8192e/rtllib.h | 20 -------------------- 1 file changed, 20 deletions(-)
drivers/staging/rtl8192e/rtllib.h +0 -20
@@ -784,26 +784,6 @@ do { \ #define RTLLIB_DEBUG_RX(f, a...) RTLLIB_DEBUG(RTLLIB_DL_RX, f, ## a) #define RTLLIB_DEBUG_QOS(f, a...) RTLLIB_DEBUG(RTLLIB_DL_QOS, f, ## a) -/* Added by Annie, 2005-11-22. */ -#define MAX_STR_LEN 64 -/* I want to see ASCII 33 to 126 only. Otherwise, I print '?'. */ -#define PRINTABLE (_ch) (_ch > '!' && _ch < '~') -#define RTLLIB_PRINT_STR (_Comp, _TitleString, _Ptr, _Len) \ - if ((_Comp) & level) { \ - int __i; \ - u8 struct buffer[MAX_STR_LEN]; \ - int length = (_Len < MAX_STR_LEN) ? _Len : (MAX_STR_LEN-1) ;\ - memset(struct buffer, 0, MAX_STR_LEN); \ - memcpy(struct buffer, (u8 *)_Ptr, length); \ - for (__i = 0; __i < MAX_STR_LEN; __i++) { \ - if (!PRINTABLE(struct buffer[__i])) \ - struct buffer[__i] = '?'; \ - } \ - struct buffer[length] = '\0'; \ - printk(KERN_INFO "Rtl819x: "); \ - printk(_TitleString); \ - printk(": %d, <%s>\n", _Len, struct buffer); \ - }#ifndef ETH_P_PAE #define ETH_P_PAE 0x888E/* Port Access Entity (IEEE 802.1X) */ #define ETH_P_IP 0x0800/* Internet Protocol packet */
Signature · 1 line
1.9.1
Quoted 2 lines · Cristina Opriceana
This patch removes the
RTLLIB_PRINT_STRmacro definition because it is olny defined in the header and it is never referenced.
Small spelling mistake. Also, the patch also removes several other macros, so you may want to mention all of them.
julia
Quoted 47 lines
Signed-off-by Cristina Opriceana <[email protected]>--- drivers/staging/rtl8192e/rtllib.h | 20 -------------------- 1 file changed, 20 deletions(-)drivers/staging/rtl8192e/rtllib.h +0
-20@@ -784,26 +784,6 @@ do { \ #define RTLLIB_DEBUG_RX(f, a...) RTLLIB_DEBUG(RTLLIB_DL_RX, f, ## a) #define RTLLIB_DEBUG_QOS(f, a...) RTLLIB_DEBUG(RTLLIB_DL_QOS, f, ## a) -/* Added by Annie, 2005-11-22. */ -#define MAX_STR_LEN 64 -/* I want to see ASCII 33 to 126 only. Otherwise, I print '?'. */ -#define PRINTABLE (_ch) (_ch > '!' && _ch < '~') -#define RTLLIB_PRINT_STR (_Comp, _TitleString, _Ptr, _Len) \ - if ((_Comp) & level) { \ - int __i; \ - u8 struct buffer[MAX_STR_LEN]; \ - int length = (_Len < MAX_STR_LEN) ? _Len : (MAX_STR_LEN-1) ;\ - memset(struct buffer, 0, MAX_STR_LEN); \ - memcpy(struct buffer, (u8 *)_Ptr, length); \ - for (__i = 0; __i < MAX_STR_LEN; __i++) { \ - if (!PRINTABLE(struct buffer[__i])) \ - struct buffer[__i] = '?'; \ - } \ - struct buffer[length] = '\0'; \ - printk(KERN_INFO "Rtl819x: "); \ - printk(_TitleString); \ - printk(": %d, <%s>\n", _Len, struct buffer); \ - }#ifndef ETH_P_PAE #define ETH_P_PAE 0x888E/* Port Access Entity (IEEE 802.1X) */ #define ETH_P_IP 0x0800/* Internet Protocol packet */ Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150309204828.GA25299%40Inspiron. For more options, visit https://groups.google.com/d/optout.
Quoted 4 lines
Small spelling mistake. Also, the patch also removes several other macros, so you may want to mention all of them.
Oh, I swapped some letters.
Thanks for reviewing.
Cristina