Skip to contentSkip to conversation

Input: sx8654 - signedness bug in sx8654_irq()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 11, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: sx8654 - signedness bug in sx8654_irq()

"irqsrc" needs to be signed for the error handling to work.

drivers/input/touchscreen/sx8654.c +1 -1
index 8e531ac..aecb9ad 100644
@@ -79,7 +79,7 @@ struct sx8654 {
 static irqreturn_t sx8654_irq(int irq, void *handle)
 {
 	struct sx8654 *sx8654 = handle;
-	u8 irqsrc;
+	int irqsrc;
 	u8 data[4];
 	unsigned int x, y;
 	int retval;
maintainer Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

"irqsrc" needs to be signed for the error handling to work.

Applied, thank you.

Quoted 13 lines
drivers/input/touchscreen/sx8654.c +1 -1
index 8e531ac..aecb9ad 100644
@@ -79,7 +79,7 @@ struct sx8654 {
 static irqreturn_t sx8654_irq(int irq, void *handle)
 {
 	struct sx8654 *sx8654 = handle;
-	u8 irqsrc;
+	int irqsrc;
 	u8 data[4];
 	unsigned int x, y;
 	int retval;
Signature · 1 line
Dmitry