Staging: iio: Simplify return logic
Subsystems (4)
PATCH 1/1 Staging: iio: Simplify return logic
This patch removes the conditional return of the ade77*_probe functions based on the return values of iio_device_register as the latter returns 0 or ret, the same as the checked values.
Warning found by coccinelle.
--- drivers/staging/iio/meter/ade7753.c | 6 +----- drivers/staging/iio/meter/ade7754.c | 6 +----- drivers/staging/iio/meter/ade7759.c | 6 +----- 3 files changed, 3 insertions(+), 15 deletions(-)
drivers/staging/iio/meter/ade7753.c +1 -5
@@ -517,11 +517,7 @@ static int ade7753_probe(struct spi_device *spi)if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */
drivers/staging/iio/meter/ade7754.c +1 -5
@@ -540,11 +540,7 @@ static int ade7754_probe(struct spi_device *spi) ret =ade7754_initial_setup (indio_dev);if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */
drivers/staging/iio/meter/ade7759.c +1 -5
@@ -462,11 +462,7 @@ static int ade7759_probe(struct spi_device *spi)if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */
Signature · 1 line
1.9.1
Quoted 7 lines · Cristina Opriceana
This patch removes the conditional return of the ade77*_probe functions based on the return values of
iio_device_registeras the latter returns 0 or ret, the same as the checked values.Warning found by coccinelle.
Signed-off-by Cristina Opriceana <[email protected]>
Quoted 66 lines
--- drivers/staging/iio/meter/ade7753.c | 6 +----- drivers/staging/iio/meter/ade7754.c | 6 +----- drivers/staging/iio/meter/ade7759.c | 6 +----- 3 files changed, 3 insertions(+), 15 deletions(-)drivers/staging/iio/meter/ade7753.c +1
-5@@ -517,11 +517,7 @@ static int ade7753_probe(struct spi_device *spi)if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */ drivers/staging/iio/meter/ade7754.c +1
-5@@ -540,11 +540,7 @@ static int ade7754_probe(struct spi_device *spi) ret =ade7754_initial_setup (indio_dev);if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */ drivers/staging/iio/meter/ade7759.c +1
-6@@ -462,11 +462,7 @@ static int ade7759_probe(struct spi_device *spi)if (ret)return ret; - ret =iio_device_register (indio_dev); -if (ret) -return ret; - -return 0 ; +return iio_device_register (indio_dev); }/* fixme, confirm ordering in this function */ --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150312171031.GA3558%40Inspiron.
For more options, visit https://groups.google.com/d/optout.