fix 'line over 80 characters'
PATCH 1/1 fix 'line over 80 characters'
This file contained a warning of a line being over 80 characters and so the file has been edited to remove that warning.
--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/octeon-usb/octeon-hcd.c +1 -1
@@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) pipe->pid_toggle =1 ;if (__cvmx_usb_pipe_needs_split (usb, pipe)) transaction->stage = -CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ; +CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ;else {struct usb_ctrlrequest *header =cvmx_phys_to_ptr (transaction->control_header);
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 5 lines · Amitoj Kaur Chawla
This file contained a warning of a line being over 80 characters and so the file has been edited to remove that warning.
Signed-off-by Amitoj Kaur Chawla <[email protected]>
Why did you put the driver name within the []? It needs to go outside of it.
Quoted 9 lines
--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/octeon-usb/octeon-hcd.c +0
-0
drivers/staging/octeon-usb/octeon-hcd.c static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) · line 2887
Quoted 5 lines
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) pipe->pid_toggle =1 ;if (__cvmx_usb_pipe_needs_split (usb, pipe)) transaction->stage = -CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ; +CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ;
This really doesn't help much, the original code is fine, there are better things to fix in this file :)
thanks,
greg k-h
Hi,
Quoted 13 lines · Amitoj Kaur Chawla
This file contained a warning of a line being over 80 characters and so the file has been edited to remove that warning.
Signed-off-by Amitoj Kaur Chawla <[email protected]>--- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/octeon-usb/octeon-hcd.c +0
-0
drivers/staging/octeon-usb/octeon-hcd.c static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) · line 2887
Quoted 5 lines
drivers/staging/octeon-usb/octeon-hcd.c +1
-1@@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel) pipe->pid_toggle =1 ;if (__cvmx_usb_pipe_needs_split (usb, pipe)) transaction->stage = -CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ; +CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE ;
This is not an improvement. The proper fix is to refactor the code to avoid deep nesting.
A.