Skip to contentSkip to conversation

Jonathan Liu : systemd: fix firmware path to match linux-firmware

oe-commits Martin Jansa 3 participants 4 messages Mar 23, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Martin Jansa

author
#1 lore raw
Quoted 23 lines · On Mon, Mar 23, 2015 at 11:27:36AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
Author: Jonathan Liu <[email protected]>
Date:   Mon Mar 23 22:18:46 2015 +1100

systemd: fix firmware path to match linux-firmware

Signed-off-by Jonathan Liu <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

---

 meta/recipes-core/systemd/systemd_219.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_219.bb +0 -0
index 5ecdda9..f2d3c13 100644

meta/recipes-core/systemd/systemd_219.bb EXTRA_OECONF = " --with-rootprefix=${rootprefix} \ · line 115

Quoted 5 lines
meta/recipes-core/systemd/systemd_219.bb +1 -1
@@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
                  --enable-split-usr \
                  --without-python \
                  --with-sysvrcnd-path=${sysconfdir} \
-                 --with-firmware-path=${rootlibdir}/firmware \
+                 --with-firmware-path=/lib/firmware \

Is this false-possitive from QA check or is this change really ignored by systemd build?

NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded

Quoted 9 lines
meta/recipes-core/systemd/systemd_219.bb +0 -0
                "
 # uclibc does not have NSS
 EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
Signature · 5 lines
-- 
_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 3 lines · Martin Jansa

WARNING: QA Issue: systemd: configure was passed unrecognised options:
--with-firmware-path [unknown-configure-option]

I for one don't see that. Do you happen to have that build to hand still? Actually seeing log.do_configure would be useful.

Ross

#3 lore raw
In reply to Martin Jansa
Quoted 19 lines · Martin Jansa
Quoted 18 lines · On Mon, Mar 23, 2015 at 11:27:36AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
Author: Jonathan Liu <[email protected]>
Date:   Mon Mar 23 22:18:46 2015 +1100

systemd: fix firmware path to match linux-firmware

Signed-off-by Jonathan Liu <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

---

  meta/recipes-core/systemd/systemd_219.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

meta/recipes-core/systemd/systemd_219.bb EXTRA_OECONF = " --with-rootprefix=${rootprefix} \ · line 115

Quoted 10 lines
meta/recipes-core/systemd/systemd_219.bb +1 -1
index 5ecdda9..f2d3c13 100644
@@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
                   --enable-split-usr \
                   --without-python \
                   --with-sysvrcnd-path=${sysconfdir} \
-                 --with-firmware-path=${rootlibdir}/firmware \
+                 --with-firmware-path=/lib/firmware \

Is this false-possitive from QA check or is this change really ignored by systemd build?

Userspace firmware loading support was actually removed, but Jonathan added it back in:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=814252efd028ec99a15303d9a551e950e49a6726
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4bd886fb0081954879aaa2f574f3c7f6ced745d5

Quoted 16 lines

NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded

Quoted 9 lines
meta/recipes-core/systemd/systemd_219.bb +0 -1
                 "
  # uclibc does not have NSS
  EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
 
--

_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits

author
#4 lore raw
Quoted 34 lines · Randy Witt
Quoted 19 lines · Martin Jansa
Quoted 18 lines · On Mon, Mar 23, 2015 at 11:27:36AM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: d3fcfe346b3472170641d9194243c4bbe06b8585
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=d3fcfe346b3472170641d9194243c4bbe06b8585
Author: Jonathan Liu <[email protected]>
Date:   Mon Mar 23 22:18:46 2015 +1100

systemd: fix firmware path to match linux-firmware

Signed-off-by Jonathan Liu <[email protected]>
Signed-off-by Richard Purdie <[email protected]>

---

  meta/recipes-core/systemd/systemd_219.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

meta/recipes-core/systemd/systemd_219.bb EXTRA_OECONF = " --with-rootprefix=${rootprefix} \ · line 115

Quoted 10 lines
meta/recipes-core/systemd/systemd_219.bb +1 -1
index 5ecdda9..f2d3c13 100644
@@ -112,7 +112,7 @@ EXTRA_OECONF = " --with-rootprefix=${rootprefix} \
                   --enable-split-usr \
                   --without-python \
                   --with-sysvrcnd-path=${sysconfdir} \
-                 --with-firmware-path=${rootlibdir}/firmware \
+                 --with-firmware-path=/lib/firmware \

Is this false-possitive from QA check or is this change really ignored by systemd build?

Quoted 5 lines

Userspace firmware loading support was actually removed, but Jonathan added it back in:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=814252efd028ec99a15303d9a551e950e49a6726
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4bd886fb0081954879aaa2f574f3c7f6ced745d5

Ah, sorry I see it now.

meta-android adds --with-firmware-path and it was applied without these patches from Jonathan. So now it should be fine and I dont need to remove android firmware path tweak.

Thanks for clarification and sorry for noise.

Quoted 18 lines
Quoted 17 lines

NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Started
WARNING: QA Issue: systemd: configure was passed unrecognised options: --with-firmware-path [unknown-configure-option]
NOTE: recipe systemd-1_219+gitAUTOINC+a88abde721-r0: task do_configure: Succeeded

Quoted 9 lines
meta/recipes-core/systemd/systemd_219.bb +0 -1
                 "
  # uclibc does not have NSS
  EXTRA_OECONF_append_libc-uclibc = " --disable-myhostname "
 
--

_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]