staging: sm750fb: Fixed C99 comments warnings

PATCH In review Ragavendra Nagraj 2 participants 2 messages Mar 24, 2015

Subsystems (3)

Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Ragavendra Nagraj

author

2015-03-24 04:51 UTC #0 lore raw

PATCH 1/1 staging: sm750fb: Fixed C99 comments warnings

This patch fixes the C99-style "// ..." comments warnings identified by the checkpath.pl script for the entire ddk750_chip.c file by using the appropriate C89 "/* ... */" style comments accordingly.

Signed-off-by Ragavendra Nagraj <[email protected]>

---
 drivers/staging/sm750fb/ddk750_chip.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

drivers/staging/sm750fb/ddk750_chip.c +6 -6

index 02f9326..1fb00a4 100644
@@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
 	char physicalRev;
 	logical_chip_type_t chip;
 
-	physicalID = devId750;//either 0x718 or 0x750
+	physicalID = devId750;/*either 0x718 or 0x750*/
 	physicalRev = revId750;
 
 	if (physicalID = 0x718)

@@ -264,7 +264,7 @@ int ddk750_initHw(initchip_param_t * pInitParam)
 
 	unsigned int ulReg;
 #if 0
-	//move the code to map regiter function.
+	/*move the code to map regiter function.*/
 	if(getChipType() = SM718){
 		/* turn on big endian bit*/
 		ulReg = PEEK32(0x74);

@@ -501,7 +501,7 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll)
 		}
 	}
 
-	//printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);
+	/*printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);*/
 	return ret;
 }

@@ -597,13 +597,13 @@ pll_value_t *pPLL           /* Structure to hold the value to be set in PLL */
 	}
 
     /* Restore input frequency from Khz to hz unit */
-//    pPLL->inputFreq *= 1000;
+/*    pPLL->inputFreq *= 1000;*/
 	ulRequestClk *= 1000;
 	pPLL->inputFreq = DEFAULT_INPUT_CLOCK; /* Default reference clock */
 
     /* Output debug information */
-	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Requested Frequency = %d\n", ulRequestClk));
-	//DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Input CLK = %dHz, M=%d, N=%d, OD=%d, POD=%d\n", pPLL->inputFreq, pPLL->M, pPLL->N, pPLL->OD, pPLL->POD));
+	/*DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Requested Frequency = %d\n", ulRequestClk));*/
+	/*DDKDEBUGPRINT((DISPLAY_LEVEL, "calcPllValue: Input CLK = %dHz, M=%d, N=%d, OD=%d, POD=%d\n", pPLL->inputFreq, pPLL->M, pPLL->N, pPLL->OD, pPLL->POD));*/
 
     /* Return actual frequency that the PLL can set */
 	ret = calcPLL(pPLL);

Signature · 1 line

1.7.10.4

Dan Carpenter

2015-03-24 07:57 UTC #1 lore raw

drivers/staging/sm750fb/ddk750_chip.c logical_chip_type_t getChipType(void) · line 20

Quoted 10 lines · Ragavendra Nagraj

drivers/staging/sm750fb/ddk750_chip.c +1 -1

index 02f9326..1fb00a4 100644
@@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void)
 	char physicalRev;
 	logical_chip_type_t chip;
 
-	physicalID = devId750;//either 0x718 or 0x750
+	physicalID = devId750;/*either 0x718 or 0x750*/

This should be:

	physicalID = devId750; /* either 0x718 or 0x750 */

drivers/staging/sm750fb/ddk750_chip.c unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll) · line 504

Quoted 6 lines

drivers/staging/sm750fb/ddk750_chip.c +1 -1

@@ -501,7 +501,7 @@ unsigned int calcPllValue(unsigned int request_orig,pll_value_t *pll)
 		}
 	}
 
-	//printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);
+	/*printk("Finally:  pll->n[%lu],m[%lu],od[%lu],pod[%lu]\n",pll->N,pll->M,pll->OD,pll->POD);*/

Just delete this dead code.

Please redo.

regards,
dan carpenter