Skip to contentSkip to conversation

usb: chipidea: usbmisc_imx: fix returnvar.cocci warnings

PATCH Julia Lawall 2 participants 2 messages Mar 25, 2015 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 201503250705.ZLF1deME%[email protected]

A message that is not in the archive (sent off-list or not yet received): 20150324234408.GA120171@athens

#2 lore raw

Please take a look.

thanks,
julia

Quoted 41 lines · kbuild test robot

TO: Peter Chen <[email protected]>
CC: "Greg Kroah-Hartman" <[email protected]>
CC: [email protected]
CC: [email protected]

drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297

Removes unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

---

Please take the patch only if it's a positive warning. Thanks!

 usbmisc_imx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/chipidea/usbmisc_imx.c +1 -2
@@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im
 	unsigned long flags;
 	struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
 	u32 val;
-	int ret = 0;
 
 	usbmisc_imx6q_init(data);
 
@@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im
 		spin_unlock_irqrestore(&usbmisc->lock, flags);
 	}
 
-	return ret;
+	return 0;
 }
 
 static int usbmisc_vf610_init(struct imx_usbmisc_data *data)
#3 lore raw
Quoted 2 lines · Julia Lawall

Please take a look.

It is strange why I did not receive it.
The patch is ok.

Quoted 50 lines

thanks,
julia

Quoted 33 lines · kbuild test robot

TO: Peter Chen <[email protected]>
CC: "Greg Kroah-Hartman" <[email protected]>
CC: [email protected]
CC: [email protected]

drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297

Removes unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

---

Please take the patch only if it's a positive warning. Thanks!

 usbmisc_imx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/chipidea/usbmisc_imx.c +0 -1
@@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im
 	unsigned long flags;
 	struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
 	u32 val;
-	int ret = 0;
 
 	usbmisc_imx6q_init(data);
 

drivers/usb/chipidea/usbmisc_imx.c static int usbmisc_imx6sx_init(struct im · line 299

Quoted 8 lines
drivers/usb/chipidea/usbmisc_imx.c +1 -1
@@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im
 		spin_unlock_irqrestore(&usbmisc->lock, flags);
 	}
 
-	return ret;
+	return 0;
 }
 
 static int usbmisc_vf610_init(struct imx_usbmisc_data *data)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Best Regards,
Peter Chen