Skip to contentSkip to conversation

Staging: rtl8192 Clean up function definition

PATCH Superseded Eddie Kovsky 2 participants 3 messages Mar 26, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8192 Clean up function definition

Change function definition to match its prototype declaration. This fixes the following warning generated by sparse:

drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol 'rtl8192_update_ratr_table' was not declared. Should it be static?

---
 drivers/staging/rtl8192u/r8192U_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_core.c +1 -1
index 8834c23d67fc..a4795afeeb9c 100644
@@ -1967,7 +1967,7 @@ static int rtl8192_handle_assoc_response(struct net_device *dev,
 }
 
 
-void rtl8192_update_ratr_table(struct net_device *dev)
+static void rtl8192_update_ratr_table(struct net_device *dev)
 {
 	struct r8192_priv *priv = ieee80211_priv(dev);
 	struct ieee80211_device *ieee = priv->ieee80211;
Signature · 1 line
2.3.4
#1 lore raw

Huh. Weird. Please, could you just move it forward instead so we don't have to have the prototype declaration?

regars,
dan carpenter

#2 lore raw
Quoted 6 lines · Dan Carpenter

Huh. Weird. Please, could you just move it forward instead so we don't have to have the prototype declaration?

regars,
dan carpenter

Dan

You're right. That's a better solution. But I already got a message from Greg that he picked this up.

I'll put together another patch to remove the prototype.

Eddie