Skip to contentSkip to conversation

ARM perf updates for 4.1

GIT PULL Will Deacon 3 participants 7 messages Mar 27, 2015 – Apr 13, 2015

lore
Share & tools
lore
#0 lore raw

Hi Russell,

Please can you pull the following ARM perf updates for 4.1? The highlight is the addition of Qualcomm Scorpion support from Stephen, but there's also a small fix and a device-tree parsing update to allow for explicit specification of PMU interrupt affinity.

Thanks,

Will

--->8

The following changes since commit 06e5801b8cb3fc057d88cb4dc03c0b64b2744cda:

Linux 4.0-rc4 (2015-03-15 17:38:20 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-rmk/perf

for you to fetch changes up to 9fd85eb502a78bd812db58bd1f668b2a06ee30a5:

ARM: pmu: add support for interrupt-affinity property (2015-03-24 15:07:57 +0000)

----------------------------------------------------------------
Stephen Boyd (3):
ARM: perf: Preparatory work for Scorpion PMU support
ARM: perf: Only reset PMxEVCNTCR registers on reset
ARM: perf: Add support for Scorpion PMUs

Suzuki K. Poulose (1):
ARM: perf: reject groups spanning multiple hardware PMUs

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

 Documentation/devicetree/bindings/arm/pmu.txt |   2 +
 arch/arm/include/asm/pmu.h                    |   1 +
 arch/arm/kernel/perf_event.c                  |  21 +-
 arch/arm/kernel/perf_event_cpu.c              |  71 +++-
 arch/arm/kernel/perf_event_v7.c               | 525 +++++++++++++++++++++++---
 5 files changed, 548 insertions(+), 72 deletions(-)
#1 lore raw

Hi Will,

Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

BTW, shouldn't the DT update go in first, or together with the code update?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 7 lines · Geert Uytterhoeven
Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

That's a harmless warning (i.e. perf will `work' as before), but I'd like to print something to say that we didn't find the property.

Quoted 1 line

BTW, shouldn't the DT update go in first, or together with the code update?

It's going via the arm64 tree (I had to choose one of the trees for the binding, since they both arm and arm64 use it).

Will

#3 lore raw

Hi Will,

Quoted 11 lines · Will Deacon
Quoted 7 lines · Geert Uytterhoeven
Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

That's a harmless warning (i.e. perf will `work' as before), but I'd like to print something to say that we didn't find the property.

Shouldn't we have a warning only if that property makes some kind of sense?

I mean, I agree on the fact that we want this property if this is an SPI, but if it is a PPI, it doesn't make any sense to have this property, and this is very well documented in the binding documentation.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150413/76f8ce8b/attachment.sig>
#5 lore raw
In reply to Will Deacon

Hi Will,

Quoted 9 lines · Will Deacon
Quoted 7 lines · Geert Uytterhoeven
Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

Quoted 7 lines

That's a harmless warning (i.e. perf will `work' as before), but I'd like to print something to say that we didn't find the property.

Quoted 1 line

BTW, shouldn't the DT update go in first, or together with the code update?

It's going via the arm64 tree (I had to choose one of the trees for the binding, since they both arm and arm64 use it).

OK. Will start to pull arm64 too into renesas-drivers...

BTW, time to start unifying arm32 and arm64? ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw
Quoted 13 lines · Geert Uytterhoeven
Quoted 12 lines · Will Deacon
Quoted 7 lines · Geert Uytterhoeven
Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

That's a harmless warning (i.e. perf will `work' as before), but I'd like to print something to say that we didn't find the property.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

BTW, shouldn't the DT update go in first, or together with the code update?

It's going via the arm64 tree (I had to choose one of the trees for the binding, since they both arm and arm64 use it).

OK. Will start to pull arm64 too into renesas-drivers...

BTW, time to start unifying arm32 and arm64? ;-)

We're already working on unifying the perf bits (the major duplication imo) by moving the bulk of it into drivers. Stay tuned!

Will

#4 lore raw
In reply to Maxime Ripard
Quoted 13 lines · Maxime Ripard
Quoted 11 lines · Will Deacon
Quoted 7 lines · Geert Uytterhoeven
Quoted 2 lines · Will Deacon

Will Deacon (1):
ARM: pmu: add support for interrupt-affinity property

As most DTSes lack this property, we now get scary warnings:

CPU PMU: Failed to parse <no-node>/interrupt-affinity[0]

That's a harmless warning (i.e. perf will `work' as before), but I'd like to print something to say that we didn't find the property.

Quoted 7 lines

Shouldn't we have a warning only if that property makes some kind of sense?

I mean, I agree on the fact that we want this property if this is an SPI, but if it is a PPI, it doesn't make any sense to have this property, and this is very well documented in the binding documentation.

Yes, that's a good point; for PPIs, the warning is nonsensical. I'll cook a fix.

Cheers,

Will