Skip to contentSkip to conversation

Staging: comedi: addi_apci_1564: Delete whitespace

PATCH Superseded Charlie Wong Super 3 participants 5 messages Mar 30, 2015 – Apr 1, 2015 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Charlie Wong Super

author
#0 lore raw

PATCH 1/1 Staging: comedi: addi_apci_1564: Delete whitespace

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:
+ unsigned int ctrl; /* interrupt mode OR (edge) . AND (level) */

Signed-off-by Charlie Wong Super <[email protected]>
---
 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1564.c +6 -6
index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
 	struct task_struct *tsk_current;
 };
Signature · 1 line
1.9.1
#1 lore raw

Review

Quoted 4 lines · Charlie Wong Super

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:

(quoted diff) +1 -0
+	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */

You don't really need the above two lines. One can see the specific file and the affected code lines just below.

julia

Quoted 39 lines
Signed-off-by Charlie Wong Super <[email protected]>
---
 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1564.c +6 -7
index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/
 	struct task_struct *tsk_current;
 };
 
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad.
For more options, visit https://groups.google.com/d/optout.

author
#2 lore raw

I got it, and I will the message and send it again, thanks !

Quoted 72 lines · Julia Lawall
Quoted 4 lines · Charlie Wong Super

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:
+ unsigned int ctrl; /* interrupt mode OR (edge) .

AND (level) */

You don't really need the above two lines. One can see the specific file and the affected code lines just below.

julia

Review

Quoted 7 lines
Signed-off-by Charlie Wong Super <[email protected] <javascript:>>

---

 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ 
 1 file changed, 6 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/comedi/drivers/addi_apci_1564.c

drivers/staging/comedi/drivers/addi_apci_1564.c line 109

Quoted 8 lines

index c481c48..dd335e8 100644

drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
@@ -106,12 +106,12 @@ 
 #define APCI1564_COUNTER(x)                        ((x) * 0x20) 
 
 struct apci1564_private { 
-        unsigned long eeprom;                /* base address of EEPROM

register */

drivers/staging/comedi/drivers/addi_apci_1564.c line 110

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned long timer;                /* base address of 12-bit

timer */

drivers/staging/comedi/drivers/addi_apci_1564.c line 111

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned long counters;                /* base address of

32-bit counters */

drivers/staging/comedi/drivers/addi_apci_1564.c line 112

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int mode1;                /* riding-edge/high level

channels */

drivers/staging/comedi/drivers/addi_apci_1564.c line 113

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int mode2;                /* falling-edge/low level

channels */

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int ctrl;                /* interrupt mode OR (edge) .

AND (level) */

drivers/staging/comedi/drivers/addi_apci_1564.c line 109

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long eeprom;                /*base address of EEPROM

register*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 110

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long timer;                /*base address of 12-bit

timer*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 111

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long counters;                /*base address of 32-bit

counters*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 112

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int mode1;                /*riding-edge/high level

channels*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 113

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int mode2;                /*falling-edge/low level

channels*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int ctrl;                /*interrupt mode OR

(edge).AND(level)*/

Quoted 8 lines
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -0
         struct task_struct *tsk_current; 
 };
Signature · 4 lines
1.9.1 

-- 
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

Quoted 72 lines · Julia Lawall
Quoted 4 lines · Charlie Wong Super

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:
+ unsigned int ctrl; /* interrupt mode OR (edge) .

AND (level) */

You don't really need the above two lines. One can see the specific file and the affected code lines just below.

julia

Review

Quoted 7 lines
Signed-off-by Charlie Wong Super <[email protected] <javascript:>>

---

 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------ 
 1 file changed, 6 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/comedi/drivers/addi_apci_1564.c

drivers/staging/comedi/drivers/addi_apci_1564.c line 109

Quoted 8 lines

index c481c48..dd335e8 100644

drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
@@ -106,12 +106,12 @@ 
 #define APCI1564_COUNTER(x)                        ((x) * 0x20) 
 
 struct apci1564_private { 
-        unsigned long eeprom;                /* base address of EEPROM

register */

drivers/staging/comedi/drivers/addi_apci_1564.c line 110

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned long timer;                /* base address of 12-bit

timer */

drivers/staging/comedi/drivers/addi_apci_1564.c line 111

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned long counters;                /* base address of

32-bit counters */

drivers/staging/comedi/drivers/addi_apci_1564.c line 112

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int mode1;                /* riding-edge/high level

channels */

drivers/staging/comedi/drivers/addi_apci_1564.c line 113

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int mode2;                /* falling-edge/low level

channels */

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -1
-        unsigned int ctrl;                /* interrupt mode OR (edge) .

AND (level) */

drivers/staging/comedi/drivers/addi_apci_1564.c line 109

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long eeprom;                /*base address of EEPROM

register*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 110

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long timer;                /*base address of 12-bit

timer*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 111

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned long counters;                /*base address of 32-bit

counters*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 112

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int mode1;                /*riding-edge/high level

channels*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 113

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int mode2;                /*falling-edge/low level

channels*/

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 1 line
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -0
+        unsigned int ctrl;                /*interrupt mode OR

(edge).AND(level)*/

Quoted 8 lines
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -0
         struct task_struct *tsk_current; 
 };
Signature · 4 lines
1.9.1 

-- 
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To post to this group, send email to [email protected]

<javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20150330154011.GA11201%40ThinkPad.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

author
#3 lore raw
In reply to Julia Lawall
Quoted 16 lines · Julia Lawall
Quoted 4 lines · Charlie Wong Super

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:
+ unsigned int ctrl; /* interrupt mode OR (edge) .

AND (level) */

You don't really need the above two lines. One can see the specific file and the affected code lines just below.

julia

Quoted 1 line

I think I make a style mistake about the that replay!

maintainer
#4 lore raw
In reply to Charlie Wong Super
Quoted 20 lines · Charlie Wong Super

This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
FILE: drivers/staging/comedi/drivers/addi_apci_1564.c:114:

(quoted diff) +1 -0
+	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
Signed-off-by Charlie Wong Super <[email protected]>
---
 drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1564.c +0 -2
index c481c48..dd335e8 100644
@@ -106,12 +106,12 @@
 #define APCI1564_COUNTER(x)			((x) * 0x20)
 
 struct apci1564_private {
-	unsigned long eeprom;		/* base address of EEPROM register */
-	unsigned long timer;		/* base address of 12-bit timer */

drivers/staging/comedi/drivers/addi_apci_1564.c line 114

Quoted 10 lines
drivers/staging/comedi/drivers/addi_apci_1564.c +6 -4
-	unsigned long counters;		/* base address of 32-bit counters */
-	unsigned int mode1;		/* riding-edge/high level channels */
-	unsigned int mode2;		/* falling-edge/low level channels */
-	unsigned int ctrl;		/* interrupt mode OR (edge) . AND (level) */
+	unsigned long eeprom;		/*base address of EEPROM register*/
+	unsigned long timer;		/*base address of 12-bit timer*/
+	unsigned long counters;		/*base address of 32-bit counters*/
+	unsigned int mode1;		/*riding-edge/high level channels*/
+	unsigned int mode2;		/*falling-edge/low level channels*/
+	unsigned int ctrl;		/*interrupt mode OR (edge).AND(level)*/

That makes things look worse :(