staging: lustre: prevent underflows in lnet_parse_reply()

PATCH New Dan Carpenter 1 participant 1 message Apr 1, 2015

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2015-04-01 08:13 UTC #0 lore raw

PATCH 2/2 staging: lustre: prevent underflows in lnet_parse_reply()

I don't know if "hdr->payload_length;" can really be negative, but if so then we shouldn't allow it. Do the comparison as an unsigned.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/lustre/lnet/lnet/lib-move.c +1 -1

index ed6eec9..9fe0c64 100644
@@ -1530,7 +1530,7 @@ lnet_parse_reply(lnet_ni_t *ni, lnet_msg_t *msg)
 	LASSERT(md->md_offset = 0);
 
 	rlength = hdr->payload_length;
-	mlength = min_t(int, rlength, md->md_length);
+	mlength = min_t(uint, rlength, md->md_length);
 
 	if (mlength < rlength &&
 	    (md->md_options & LNET_MD_TRUNCATE) = 0) {