Skip to contentSkip to conversation

tracing/drm: Remove unused TRACE_SYSTEM_STRING define

RFC PATCH New Steven Rostedt 1 participant 1 message Apr 2, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 tracing/drm: Remove unused TRACE_SYSTEM_STRING define

The tracing infrastructure is adding a macro TRACE_SYSTEM_STRING, and hit the following build failure:

In file included from include/trace/define_trace.h:90:0,

                    from drivers/gpu/drm/.//radeon/radeon_trace.h:209,
                    from drivers/gpu/drm/.//radeon/radeon_trace_points.c:9:
Quoted 1 line
Quoted 1 line

include/trace/ftrace.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined

    #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)

Seems that the DRM folks have added their own use to the TRACE_SYSTEM_STRING, with:

#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)

Although, I can not find its use anywhere. I could simply use another name, but if this macro is not being used, it should be removed.

Cc Alex Deucher <[email protected]>
Cc Christian König <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Jani Nikula <[email protected]>

---

Acks please.

drivers/gpu/drm/drm_trace.h +0 -1
index 27cc95f36381..ce3c42813fbb 100644
@@ -7,7 +7,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM drm
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
 #define TRACE_INCLUDE_FILE drm_trace
 
 TRACE_EVENT(drm_vblank_event,
drivers/gpu/drm/i915/i915_trace.h +0 -1
index 6058a01b4443..d776621c8521 100644
@@ -12,7 +12,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM i915
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
 #define TRACE_INCLUDE_FILE i915_trace
 
 /* pipe updates */
drivers/gpu/drm/radeon/radeon_trace.h +0 -1
index ce075cb08cb2..fdce4062901f 100644
@@ -9,7 +9,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM radeon
-#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
 #define TRACE_INCLUDE_FILE radeon_trace
 
 TRACE_EVENT(radeon_bo_create,

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx