ocfs2: double evaluation concerns in mlog_errno()

PATCH New Dan Carpenter 1 participant 1 message Apr 3, 2015

Subsystems (2)

Kernel janitors OCFS2

lore

Share & tools

lore

Dan Carpenter

author

2015-04-03 08:33 UTC #0 lore raw

PATCH 1/1 ocfs2: double evaluation concerns in mlog_errno()

It won't happen in real life, but for consistency etc then we should only evaluate the "st" parameter once.

Also, since not all callers use the new return, it causes at static checker warning:
fs/ocfs2/export.c:138 ocfs2_get_dentry() warn: unchecked 'PTR_ERR'

Signed-off-by Dan Carpenter <[email protected]>

fs/ocfs2/cluster/masklog.h +1 -1

index f96a51d..7fdc25a 100644
@@ -202,7 +202,7 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits;
 	    _st != AOP_TRUNCATED_PAGE && _st != -ENOSPC &&		\
 	    _st != -EDQUOT)						\
 		mlog(ML_ERROR, "status = %lld\n", (long long)_st);	\
-	st;								\
+	_st;								\
 })
 
 #define mlog_bug_on_msg(cond, fmt, args...) do {			\