Skip to contentSkip to conversation

spi: signedness bug in qspi_trigger_transfer_out_int()

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 3, 2015 – Apr 6, 2015

Subsystems (2)
Kernel janitors SPI
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 spi: signedness bug in qspi_trigger_transfer_out_int()

We need "ret" to be unsigned for the error handling to work. The signedness of "i" and "n" don't matter but qspi_set_send_trigger() returns an int so I've changed them to int as well.

Fixes 4b6fe3edcbba ('spi: Using Trigger number to transmit/receive data')
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-rspi.c +1 -1
index b3871d8..f6bac9e 100644
@@ -727,7 +727,7 @@ static int rspi_rz_transfer_one(struct spi_master *master,
 static int qspi_trigger_transfer_out_int(struct rspi_data *rspi, const u8 *tx,
 					u8 *rx, unsigned int len)
 {
-	unsigned int i, n, ret;
+	int i, n, ret;
 	int error;
 
 	while (len > 0) {
#1 lore raw

Hi,

Quoted 14 lines · Dan Carpenter

We need "ret" to be unsigned for the error handling to work. The signedness of "i" and "n" don't matter but qspi_set_send_trigger() returns an int so I've changed them to int as well.

Fixes 4b6fe3edcbba ('spi: Using Trigger number to transmit/receive data')
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-rspi.c +0 -0
index b3871d8..f6bac9e 100644

drivers/spi/spi-rspi.c static int rspi_rz_transfer_one(struct spi_master *master, · line 733

Quoted 8 lines
drivers/spi/spi-rspi.c +1 -1
@@ -727,7 +727,7 @@ static int rspi_rz_transfer_one(struct spi_master *master,
  static int qspi_trigger_transfer_out_int(struct rspi_data *rspi, const u8 *tx,
  					u8 *rx, unsigned int len)
  {
-	unsigned int i, n, ret;
+	int i, n, ret;
  	int error;
 
  	while (len > 0) {

Thanks for your patch!

Best Regards,
Hiep.

maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 3 lines · Dan Carpenter

We need "ret" to be unsigned for the error handling to work. The signedness of "i" and "n" don't matter but qspi_set_send_trigger() returns an int so I've changed them to int as well.

Applied, thanks.