Skip to contentSkip to conversation

staging: sm7xxfb: Fix sparse warning

PATCH In review Nickolaus Woodruff 2 participants 2 messages Apr 4, 2015

Subsystems (2)
Staging Framebuffer layer
lore
Share & tools
lore

Nickolaus Woodruff

author
#0 lore raw

PATCH 1/1 staging: sm7xxfb: Fix sparse warning

This patch fixes the following sparse warning in sm7xx.h:

drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' was not declared. Should it be static?

Signed-off-by Nickolaus Woodruff <[email protected]>
---
 drivers/staging/sm7xxfb/sm7xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xx.h +1 -1
index 7cc1896..c5d6253 100644
@@ -119,7 +119,7 @@ struct ModeInit {
 /**********************************************************************
 			 SM712 Mode table.
  **********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
 	{
 	 /*  mode#0: 640 x 480  16Bpp  60Hz */
 	 640, 480, 16, 60,

--
1.9.1

#1 lore raw
Quoted 15 lines · Nickolaus Woodruff

This patch fixes the following sparse warning in sm7xx.h:

drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' was not declared. Should it be static?

Signed-off-by Nickolaus Woodruff <[email protected]>
---
 drivers/staging/sm7xxfb/sm7xx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xx.h +0 -0
index 7cc1896..c5d6253 100644

drivers/staging/sm7xxfb/sm7xx.h struct ModeInit { · line 122

Quoted 5 lines
drivers/staging/sm7xxfb/sm7xx.h +1 -1
@@ -119,7 +119,7 @@ struct ModeInit {
 /**********************************************************************
 			 SM712 Mode table.
  **********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {

Someone already fixed this:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/sm7xxfb/sm7xx.h?h=staging-testing#n122
Please work against staging-testing branch of the staging tree.

Su pagarba / Regards,
Giedrius