Upstream kernel fails to run on qemu-sparc64 due to commit 889fa31f0 (blk-mq: reduce unnecessary software queue looping)
Hi,
my qemu-sparc64 tests fail to run with kernel v4.0-7245-ga39ef1a7c609. Bisect points to commit 889fa31f00b ("blk-mq: reduce unnecessary software queue looping"). Reverting this commit fixes the problem.
I had a look into the commit, but I have no idea what might be wrong.
I made the bisect log, images, configuration file, root file system, and directions on how to run the images available at http://server.roeck-us.net/qemu/sparc64.
Please let me know if there is any other information I can provide.
Guenter
Quoted 6 lines · Guenter Roeck
Hi,
my qemu-sparc64 tests fail to run with kernel v4.0-7245-ga39ef1a7c609. Bisect points to commit
889fa31f00b("blk-mq: reduce unnecessary software queue looping"). Reverting this commit fixes the problem.
Quoted 7 lines
I had a look into the commit, but I have no idea what might be wrong.
I made the bisect log, images, configuration file, root file system, and directions on how to run the images available at http://server.roeck-us.net/qemu/sparc64.
Please let me know if there is any other information I can provide.
As additional information:
+ * Set the map size to the number of mapped software queues. + * This is more accurate and more efficient than looping + * over all possibly mapped software queues. + */
+ map->map_size = hctx->nr_ctx / map->bits_per_word;
On my system, hctx->nr_ctx is 1, and map->bits_per_word is 8. Thus map->map_size is set to 0, which doesn't make much sense. The system comes up if I replace the above code with
map->map_size = DIV_ROUND_UP(hctx->nr_ctx, map->bits_per_word);
I have no idea if that is the correct fix, though.
Guenter
Quoted 22 lines · Guenter Roeck
Quoted 6 lines · Guenter Roeck
Hi,
my qemu-sparc64 tests fail to run with kernel v4.0-7245-ga39ef1a7c609. Bisect points to commit
889fa31f00b("blk-mq: reduce unnecessary software queue looping"). Reverting this commit fixes the problem.Quoted 7 lines
I had a look into the commit, but I have no idea what might be wrong.
I made the bisect log, images, configuration file, root file system, and directions
on how to run the images available at https://urldefense.proofpoint.com/v1/url?u=http://server.roeck-us.net/qemu/sparc64&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=%2FUVX9MC8j8RmqOwlL6HnyBe%2FFSO5xSJdG3GTTzADFYk%3D%0A&s=caaf39bb4246d5223f9dea93771fdb075f9046b6fdf1822b7da21d7665da71d5.Please let me know if there is any other information I can provide.
As additional information:
(quoted diff) +5
-0+ * Set the map size to the number of mapped software queues. + * This is more accurate and more efficient than looping + * over all possibly mapped software queues. + */ + map->map_size = hctx->nr_ctx / map->bits_per_word;
Quoted 8 lines
On my system,
hctx->nr_ctxis 1, andmap->bits_per_wordis 8. Thusmap->map_sizeis set to 0, which doesn't make much sense.The system comes up if I replace the above code with
map->map_size = DIV_ROUND_UP(hctx->nr_ctx, map->bits_per_word);I have no idea if that is the correct fix, though.
Ugh, yes indeed, looks like the <= was lost from a previous patch. Now I wonder why it I didn't see any hangs with this... Thanks for reporting, I'll get a fix in today.
Signature · 1 line
Jens Axboe
Hi Jens,
Quoted 13 lines · Jens Axboe
Quoted 11 lines
Quoted 1 line
As additional information:
(quoted diff) +5
-0+ * Set the map size to the number of mapped software queues. + * This is more accurate and more efficient than looping + * over all possibly mapped software queues. + */ + map->map_size = hctx->nr_ctx / map->bits_per_word;On my system,
hctx->nr_ctxis 1, andmap->bits_per_wordis 8. Thusmap->map_sizeis set to 0, which doesn't make much sense.
Quoted 9 lines
Quoted 4 lines
The system comes up if I replace the above code with
map->map_size = DIV_ROUND_UP(hctx->nr_ctx, map->bits_per_word);I have no idea if that is the correct fix, though.
Ugh, yes indeed, looks like the <= was lost from a previous patch. Now I wonder why it I didn't see any hangs with this... Thanks for reporting, I'll get a fix in today.
Assuming that nr_ctx reflects the number of (online) CPUs, my guess is that you may have a multiple of bits_per_word CPUs in your system.
Guenter
Quoted 19 lines · Guenter Roeck
Hi Jens,
Quoted 16 lines · Jens Axboe
Quoted 16 lines
Quoted 1 line
As additional information:
(quoted diff) +5
-0+ * Set the map size to the number of mapped software queues. + * This is more accurate and more efficient than looping + * over all possibly mapped software queues. + */ + map->map_size = hctx->nr_ctx / map->bits_per_word;On my system,
hctx->nr_ctxis 1, andmap->bits_per_wordis 8. Thusmap->map_sizeis set to 0, which doesn't make much sense.The system comes up if I replace the above code with
map->map_size = DIV_ROUND_UP(hctx->nr_ctx, map->bits_per_word);
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
I have no idea if that is the correct fix, though.
Ugh, yes indeed, looks like the <= was lost from a previous patch. Now I wonder why it I didn't see any hangs with this... Thanks for reporting, I'll get a fix in today.
Assuming that
nr_ctxreflects the number of (online) CPUs, my guess is that you may have a multiple ofbits_per_wordCPUs in your system.
Ah yes, now it makes sense. Smallest box I have is 8 CPUs, and generally map bits_per_word is in the 5-6 range. So it ends up working out for my case, ->map_size would be >= 1.
Signature · 1 line
Jens Axboe