Skip to contentSkip to conversation

ACPI SBS: Re-enable battery manager

PATCH Applied Chris Bainbridge 2 participants 2 messages Apr 22, 2015 – Apr 29, 2015 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI SBS: Re-enable battery manager

Commit 9faf6136 introduced a regression disabling the SBS battery manager. The battery manager should be marked as present when acpi_manager_get_info returns 0.

---
 drivers/acpi/sbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/sbs.c +1 -1
index cd82762..01504c8 100644
@@ -684,7 +684,7 @@ static int acpi_sbs_add(struct acpi_device *device)
 	if (!sbs_manager_broken) {
 		result = acpi_manager_get_info(sbs);
 		if (!result) {
-			sbs->manager_present = 0;
+			sbs->manager_present = 1;
 			for (id = 0; id < MAX_SBS_BAT; ++id)
 				if ((sbs->batteries_supported & (1 << id)))
 					acpi_battery_add(sbs, id);
Signature · 1 line
2.1.4
#1 lore raw
Quoted 5 lines · Chris Bainbridge

Commit 9faf6136 introduced a regression disabling the SBS battery manager. The battery manager should be marked as present when acpi_manager_get_info returns 0.

Applied, thanks!

Quoted 18 lines
---
 drivers/acpi/sbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/sbs.c +1 -1
index cd82762..01504c8 100644
@@ -684,7 +684,7 @@ static int acpi_sbs_add(struct acpi_device *device)
 	if (!sbs_manager_broken) {
 		result = acpi_manager_get_info(sbs);
 		if (!result) {
-			sbs->manager_present = 0;
+			sbs->manager_present = 1;
 			for (id = 0; id < MAX_SBS_BAT; ++id)
 				if ((sbs->batteries_supported & (1 << id)))
 					acpi_battery_add(sbs, id);
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.