Staging: dgnc: Replace snprintf instead of sprintf
PATCH 1/1 Staging: dgnc: Replace snprintf instead of sprintf
This patch replaces snprintf instead of sprintf to avoid buffer overflow
Signed-off-by Gnanachandran Dhanapal <[email protected]>
--- drivers/staging/dgnc/dgnc_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_mgmt.c +1 -1
@@ -116,7 +116,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)spin_lock_irqsave (&dgnc_global_lock, flags); ddi.dinfo_nboards = dgnc_NumBoards; -sprintf (ddi.dinfo_version,"%s" ,DG_PART ); +snprintf (ddi.dinfo_version,strlen (DG_PART )+1 ,"%s" ,DG_PART );spin_unlock_irqrestore (&dgnc_global_lock, flags);
Signature · 1 line
1.7.9.5
Quoted 12 lines · GNANACHANDRAN (G.)
This patch replaces snprintf instead of sprintf to avoid buffer overflow
Signed-off-by Gnanachandran Dhanapal <[email protected]>--- drivers/staging/dgnc/dgnc_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/dgnc/dgnc_mgmt.c +0
-0
drivers/staging/dgnc/dgnc_mgmt.c long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) · line 119
Quoted 5 lines
drivers/staging/dgnc/dgnc_mgmt.c +1
-1@@ -116,7 +116,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)spin_lock_irqsave (&dgnc_global_lock, flags); ddi.dinfo_nboards = dgnc_NumBoards; -sprintf (ddi.dinfo_version,"%s" ,DG_PART ); +snprintf (ddi.dinfo_version,strlen (DG_PART )+1 ,"%s" ,DG_PART );
This change makes no sense. If the original had memory corruption then the new code has memory corruption as well.
regards,
dan carpenter