progs bug(ish?) report
Hi, Dave,
Not sure if it really counts as a bug, mostly just an
inconvenience, but ./configure completes happily, and then make fails with:
btrfs-convert.c:27:21: fatal error: sys/acl.h: No such file or directory
so I guess it needs an additional check for libacl1. I can't see a pkg-config entry for it on my system. OTOH, I don't see where there's any linkage with libacl in the makefile, and it's clearly finding the include files successfully.
Maybe something like this?
AC_CHECK_LIB([acl1], [acl_init], [],
[AC_MSG_ERROR([cannot find acl1 library])])
Hugo.
Signature · 4 lines
Hugo Mills | The Creature from the Black Logon hugo@... carfax.org.uk | http://carfax.org.uk/ | PGP: E2AB1DE4 |
Quoted 5 lines · Hugo Mills
Not sure if it really counts as a bug, mostly just an
inconvenience, but ./configure completes happily, and then make fails with:btrfs-convert.c:27:21: fatal error:
sys/acl.h: No such file or directory
Thanks, it's a bug.
Quoted 4 lines
so I guess it needs an additional check for libacl1. I can't see a pkg-config entry for it on my system. OTOH, I don't see where there's any linkage with libacl in the makefile, and it's clearly finding the include files successfully.
Right, btrfs-convert does not link against libacl. I can see it use some of the ACL_ macros (simple values only) and none of the functions provided by libacl. For that reason I'd rather avoid dependency on the library and copy the values.
The acl values are directly read from the extN data, so it's more part of the on-disk format than an interface to libacl. For that reason I'm not worried about having the local copy. I'll fix that.