Skip to contentSkip to conversation

staging: lustre: lclient: lcommon_cl.c fixing coding style issues

PATCH Ankit Garg 1 participant 1 message May 6, 2015 Staging

lore
Share & tools
lore

Ankit Garg

author
#0 lore raw

This patch fixes the checkpatch.pl warning:

WARNING: else is not generally useful after a break or return
+ return result;
+ } else {

---
 drivers/staging/lustre/lustre/lclient/lcommon_cl.c |   35 ++++++++++----------
 1 file changed, 17 insertions(+), 18 deletions(-)
drivers/staging/lustre/lustre/lclient/lcommon_cl.c +17 -18
index ab6cb41..1c96ede 100644
@@ -836,25 +836,24 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
 					*exceed = 1;
 			}
 			return result;
-		} else {
-			/*
-			 * region is within kms and, hence, within real file
-			 * size (A). We need to increase i_size to cover the
-			 * read region so that generic_file_read() will do its
-			 * job, but that doesn't mean the kms size is
-			 * _correct_, it is only the _minimum_ size. If
-			 * someone does a stat they will get the correct size
-			 * which will always be >= the kms value here.
-			 * b=11081
-			 */
-			if (cl_isize_read(inode) < kms) {
-				cl_isize_write_nolock(inode, kms);
-				CDEBUG(D_VFSTRACE,
-				       DFID" updating i_size %llu\n",
-				       PFID(lu_object_fid(&obj->co_lu)),
-				       (__u64)cl_isize_read(inode));
+		}
+		/*
+		 * region is within kms and, hence, within real file
+		 * size (A). We need to increase i_size to cover the
+		 * read region so that generic_file_read() will do its
+		 * job, but that doesn't mean the kms size is
+		 * _correct_, it is only the _minimum_ size. If
+		 * someone does a stat they will get the correct size
+		 * which will always be >= the kms value here.
+		 * b=11081
+		 */
+		if (cl_isize_read(inode) < kms) {
+			cl_isize_write_nolock(inode, kms);
+			CDEBUG(D_VFSTRACE,
+					DFID" updating i_size %llu\n",
+					PFID(lu_object_fid(&obj->co_lu)),
+					(__u64)cl_isize_read(inode));
 
-			}
 		}
 	}
 	ccc_object_size_unlock(obj);
Signature · 1 line
1.7.9.5