staging: comedi: coding style identation error fix

PATCH In review Jaime Arrocha 3 participants 5 messages May 6, 2015 – May 7, 2015 Staging

Share & tools

Jaime Arrocha

author

2015-05-06 22:13 UTC #0 lore raw

PATCH 1/1 staging: comedi: coding style identation error fix

Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50

Signed-off-by Jaime Arrocha <[email protected]>

---
 drivers/staging/comedi/drivers/das16m1.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/comedi/drivers/das16m1.c +2 -2

index 1adf6a7..a18a887 100644
@@ -46,8 +46,8 @@ list has 2 or more channels in it, then two conditions must be satisfied:
 (2) - the list must have an even number of entries.
 
 Options:
-        [0] - base io address
-        [1] - irq (optional, but you probably want it)
+	[0] - base io address
+	[1] - irq (optional, but you probably want it)
 
 irq can be omitted, although the cmd interface will not work without it.
 */

Signature · 1 line

1.7.10.4

Sudip Mukherjee

2015-05-07 05:35 UTC #1 lore raw

Quoted 7 lines · Jaime Arrocha

Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-by Jaime Arrocha <[email protected]>
---

you are sending this patch second time with different subject. any reason for that?

regards
sudip

Jaime Arrocha

2015-05-07 13:55 UTC #2 lore raw

Quoted 6 lines · Sudip Mukherjee

Quoted 5 lines · Jaime Arrocha
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50

Quoted 8 lines

Quoted 2 lines
Signed-off-by Jaime Arrocha <[email protected]>
---
you are sending this patch second time with different subject. any reason for that?
regards
sudip

Yes, the first one had the subject line too long and not clear.
When I need to resend a patch like I did, should I add on the second one the reason behind resending and dismissing the first one? Thank you.

Sudip Mukherjee

2015-05-07 13:21 UTC #3 lore raw

Quoted 14 lines · Jaime Arrocha

Quoted 11 lines · Sudip Mukherjee
Quoted 7 lines · Jaime Arrocha
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-by Jaime Arrocha <[email protected]>
---
you are sending this patch second time with different subject. any reason for that?

Quoted 8 lines

Quoted 3 lines
regards
sudip
Yes, the first one had the subject line too long and not clear. When I need to resend a patch like I did, should I add on the second one the reason behind resending and dismissing the first one? Thank you.

first of all you should reply to the first patch stating that should not be applied and that you have sent a second patch. And this one should have had a v2 in the subject with the reason of v2 below the --- cutoff. since you have already sent the second patch just reply to the fist patch as of now.
And you have sent the patches to [email protected], it should have been [email protected] . always use get_maintainer.pl to see whom to send patches.

regards
sudip

Jaime Arrocha

2015-05-07 14:37 UTC #4 lore raw

Quoted 33 lines · Sudip Mukherjee

Quoted 14 lines · Jaime Arrocha
Quoted 11 lines · Sudip Mukherjee
Quoted 7 lines · Jaime Arrocha
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-by Jaime Arrocha <[email protected]>
---
you are sending this patch second time with different subject. any reason for that?
Quoted 8 lines
Quoted 3 lines
regards
sudip
Yes, the first one had the subject line too long and not clear. When I need to resend a patch like I did, should I add on the second one the reason behind resending and dismissing the first one? Thank you.
first of all you should reply to the first patch stating that should not be applied and that you have sent a second patch. And this one should have had a v2 in the subject with the reason of v2 below the --- cutoff. since you have already sent the second patch just reply to the fist patch as of now.
And you have sent the patches to [email protected], it should have been [email protected] . always use get_maintainer.pl to see whom to send patches.

Quoted 4 lines

regards
sudip

Thanks Sudip, I will dismiss this one too and do it correctly. I accidentally took Greg's email from the TODO file.

This patch should not be applied.

Thanks,
jaime