Skip to contentSkip to conversation

perf tools: Event naming inconsistency

DISCUSSION Arnaldo Carvalho de Melo 1 participant 1 message May 11, 2015

lore
Share & tools
lore
#0 lore raw

Hi Jiri,

Noticed this while testing the PERF_RECORD_LOST_SAMPLES
patchkit:

[root@zoo ~]# perf record -e '{cycles,instructions}:p' usleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ] [root@zoo ~]# perf record -e '{cycles:p,instructions:p}' usleep 1 [ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (16 samples) ] [root@zoo ~]#

Thse should be equivalent, right?

If I do:

[root@zoo ~]# perf evlist -i perf.data.old
cycles
instructions
[root@zoo ~]# perf evlist -i perf.data
cycles:p
instructions:p
[root@zoo ~]#

But:

[root@zoo ~]# perf evlist -v -i perf.data.old
cycles: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1
instructions: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1 [root@zoo ~]#

[root@zoo ~]# perf evlist -v -i perf.data
cycles:p: size: 112, { sample_period, sample_freq }: 4000, sample_type:
IP|TID|TIME|ID|PERIOD, read_format: ID, disabled: 1, inherit: 1, mmap:
1, comm: 1, freq: 1, enable_on_exec: 1, task: 1, precise_ip: 1,
sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1 instructions:p: size: 112, config: 1, { sample_period, sample_freq }:
4000, sample_type: IP|TID|TIME|ID|PERIOD, read_format: ID, inherit: 1,
freq: 1, precise_ip: 1, sample_id_all: 1, exclude_guest: 1 [root@zoo ~]#

Both are exactly the same, would be nice that tooling when showing both cases showed the same event name, to avoid confusion... Anyway, not that high prio ;-)

- Arnaldo