Skip to contentSkip to conversation

tools selftests: Fix 'clean' target with make 3.81

PATCH In review Arnaldo Carvalho de Melo 2 participants 3 messages May 14, 2015 Kselftest

lore
Share & tools
lore

Arnaldo Carvalho de Melo

author
#0 lore raw

PATCH 1/1 tools selftests: Fix 'clean' target with make 3.81

Make 3.81 doesn't have the 'undefine' command, use 'override var =' instead.

Tested-by Shuah Khan <[email protected]>
Cc David Ahern <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Michael Ellerman <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +1 -1
index 95abddcd7839..f76830643086 100644
@@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
 # Makefile to avoid test build failures when test
 # Makefile doesn't have explicit build rules.
 ifeq (1,$(MAKELEVEL))
-undefine LDFLAGS
+override LDFLAGS =
 override MAKEFLAGS =
 endif
Signature · 1 line
2.1.0
#1 lore raw
Quoted 19 lines · Arnaldo Carvalho de Melo

Make 3.81 doesn't have the 'undefine' command, use 'override var =' instead.

Tested-by Shuah Khan <[email protected]>
Cc David Ahern <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Michael Ellerman <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/Makefile +0 -0
index 95abddcd7839..f76830643086 100644

tools/testing/selftests/Makefile TARGETS_HOTPLUG += memory-hotplug · line 33

Quoted 8 lines
tools/testing/selftests/Makefile +1 -1
@@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
 # Makefile to avoid test build failures when test
 # Makefile doesn't have explicit build rules.
 ifeq (1,$(MAKELEVEL))
-undefine LDFLAGS
+override LDFLAGS =
 override MAKEFLAGS =
 endif

I will get this into 4.2 unless you think there is real need for this to go into 4.1 right away.

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978
author
#2 lore raw

Em Thu, May 14, 2015 at 04:16:51PM -0600, Shuah Khan escreveu:

Quoted 10 lines · Arnaldo Carvalho de Melo

tools/testing/selftests/Makefile TARGETS_HOTPLUG += memory-hotplug · line 29

Quoted 6 lines

+++ b/tools/testing/selftests/Makefile

tools/testing/selftests/Makefile +1 -1
@@ -27,7 +27,7 @@ TARGETS_HOTPLUG += memory-hotplug
 ifeq (1,$(MAKELEVEL))
-undefine LDFLAGS
+override LDFLAGS =
 override MAKEFLAGS =

I will get this into 4.2 unless you think there is real need for this to go into 4.1 right away.

Send it when its most convenient to you, this is trivial, odd corner case stuff.

- Arnaldo