flow_dissect: use programable dissector in skb_flow_dissect and friends

DISCUSSION Dan Carpenter 2 participants 2 messages May 15, 2015 Kernel janitors

Share & tools

Dan Carpenter

author

2015-05-15 09:54 UTC #0 lore raw

Hello Jiri Pirko,

The patch 06635a35d13d: "flow_dissect: use programable dissector in skb_flow_dissect and friends" from May 12, 2015, leads to the following static checker warning:

	net/core/flow_dissector.c:283 __skb_flow_dissect()
	info: ignoring unreachable code.

net/core/flow_dissector.c
279
280 if (skb_flow_dissector_uses_key(flow_dissector,
281 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {

   282                          return true;
                                ^^^^^^^^^^^^

283 key_addrs = skb_flow_dissector_target(flow_dissector,
284 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
285 target_container);
286 key_addrs->src = hdr->srcnode;
287 key_addrs->dst = 0;
288 }
289 return true;

regards,
dan carpenter

Jiri Pirko

2015-05-15 10:30 UTC #1 lore raw

Quoted 23 lines · Fri, May 15, 2015 at 11:54:31AM CEST, [email protected] wrote:

Hello Jiri Pirko,
The patch 06635a35d13d: "flow_dissect: use programable dissector in skb_flow_dissect and friends" from May 12, 2015, leads to the following static checker warning:
	net/core/flow_dissector.c:283 __skb_flow_dissect()
	info: ignoring unreachable code.
net/core/flow_dissector.c
279
280 if (skb_flow_dissector_uses_key(flow_dissector,
281 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS)) {
  282                          return true;
                               ^^^^^^^^^^^^
283 key_addrs = skb_flow_dissector_target(flow_dissector,
284 FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
285 target_container);
286 key_addrs->src = hdr->srcnode;
287 key_addrs->dst = 0;
288 }
289 return true;

Quoted 2 lines

regards,
dan carpenter

Will fix that.

Thanks!