Skip to contentSkip to conversation

rtlwifi: rtl8821ae: Move driver from staging to regular tree

DISCUSSION Dan Carpenter 1 participant 1 message May 18, 2015

lore
Share & tools
lore
#0 lore raw

Hello Larry Finger,

The patch 21e4b0726dc6: "rtlwifi: rtl8821ae: Move driver from staging to regular tree" from Sep 22, 2014, leads to the following static checker warning:

	drivers/net/wireless/rtlwifi/rtl8821ae/hw.c:2183 _rtl8821ae_set_media_status()
	warn: masked condition is always false. '(bt_msr & 252) == 3'

drivers/net/wireless/rtlwifi/rtl8821ae/hw.c

  2181          rtl_write_byte(rtlpriv, MSR, bt_msr);
  2182          rtlpriv->cfg->ops->led_control(hw, ledaction);
  2183          if ((bt_msr & 0xfc) == MSR_AP)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^

This condition is never true. We mask out the 0xfc flags at the beginning of the function. MSR_AP is 0x3.

  2184                  rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
  2185          else
  2186                  rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
  2187  
  2188          return 0;
  2189  }

regards,
dan carpenter