Skip to contentSkip to conversation

drivers/gpu/drm/i915/i915_gem_gtt.c

DISCUSSION Andrew Morton 4 participants 5 messages May 22, 2015 – May 26, 2015

lore
Share & tools
lore
#0 lore raw

I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing?

Anyway, I don't know how to fix this i386 build error:

drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init':
drivers/gpu/drm/i915/i915_gem_gtt.c:954:2: error: large integer implicitly truncated to unsigned type [-Werror=overflow]

        ppgtt->base.total = 1ULL << 32;

i915_address_space.total is a ulong: 32-bit.

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw
Quoted 5 lines · Andrew Morton

I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing?

Anyway, I don't know how to fix this i386 build error:

Seems like you have CONFIG_DRM_I915_WERROR set?

We explicitely made sure to not enable -Werror by default, because different versions of gcc will generate different set of warnings making it roughly impossible to use -Werror by default (say, newer versions of gcc with more clever warnings trying to compile old commits while bisecting)

Signature · 5 lines
Damien
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 8 lines · On Sat, 23 May 2015 14:30:09 +0100 Damien Lespiau <[email protected]>…
Quoted 5 lines · Andrew Morton

I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing?

Anyway, I don't know how to fix this i386 build error:

Seems like you have CONFIG_DRM_I915_WERROR set?

Yes.

Quoted 1 line

We explicitely made sure to not enable -Werror by default,

`make allmodconfig' enables CONFIG_DRM_I915_WERROR.

I'm not sure what is the approved way of fixing this. Perhaps disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 9 lines · Andrew Morton
Quoted 7 lines · On Sat, 23 May 2015 14:30:09 +0100 Damien Lespiau <[email protected]>…
Quoted 5 lines · Andrew Morton

I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing?

Anyway, I don't know how to fix this i386 build error:

Quoted 7 lines
Quoted 1 line

Seems like you have CONFIG_DRM_I915_WERROR set?

Yes.

Quoted 1 line

We explicitely made sure to not enable -Werror by default,

`make allmodconfig' enables CONFIG_DRM_I915_WERROR.

Right.

Quoted 2 lines

I'm not sure what is the approved way of fixing this. Perhaps disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.

Maybe the answer right now is to just drop that config. Daniel?

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
Quoted 4 lines · Jani Nikula
Quoted 2 lines

I'm not sure what is the approved way of fixing this. Perhaps disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.

Maybe the answer right now is to just drop that config. Daniel?

Agreed, that little experiment doesn't seem to be worth the trouble. I've pushed/sent-out the revert.

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx