w1: fix for loop exit condition in w1_seq_show()

PATCH In review Dan Carpenter 1 participant 1 message Jun 1, 2015

Subsystems (2)

Kernel janitors W1 dallas's 1-wire bus

lore

Share & tools

lore

Dan Carpenter

author

2015-06-01 09:55 UTC #0 lore raw

PATCH 1/2 w1: fix for loop exit condition in w1_seq_show()

The W1_42_FINISHED_BYTE is 0xFF so the cast means the condition is never true.

Fixes d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')

Signed-off-by Dan Carpenter <[email protected]>

drivers/w1/slaves/w1_therm.c +1 -1

index d21e686..3351be6 100644
@@ -378,7 +378,7 @@ static ssize_t w1_seq_show(struct device *device,
 		w1_write_8(sl->master, W1_42_COND_READ);
 		rv = w1_read_block(sl->master, (u8 *)&rn, 8);
 		reg_num = (struct w1_reg_num *) &rn;
-		if ((char)reg_num->family = W1_42_FINISHED_BYTE)
+		if (reg_num->family = W1_42_FINISHED_BYTE)
 			break;
 		if (sl->reg_num.id = reg_num->id)
 			seq = i;