staging: wilc1000: prevent some overflows in debugfs

PATCH New Dan Carpenter 1 participant 1 message Jun 4, 2015

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2015-06-04 08:59 UTC #0 lore raw

PATCH 1/1 staging: wilc1000: prevent some overflows in debugfs

Add some limits here so we don't corrupt memory.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/wilc1000/wilc_debugfs.c +6 -0

index 74b9fd5..c328208 100644
@@ -53,6 +53,9 @@ static ssize_t wilc_debug_level_write(struct file *filp, const char *buf, size_t
 	char buffer[128] = {};
 	int flag = 0;
 
+	if (count > sizeof(buffer))
+		return -EINVAL;
+
 	if (copy_from_user(buffer, buf, count)) {
 		return -EFAULT;
 	}

@@ -99,6 +102,9 @@ static ssize_t wilc_debug_region_write(struct file *filp, const char *buf, size_
 	char buffer[128] = {};
 	int flag;
 
+	if (count > sizeof(buffer))
+		return -EINVAL;
+
 	if (copy_from_user(buffer, buf, count)) {
 		return -EFAULT;
 	}