drm/amdgpu: off by one check in dce_v8_0_hpd_irq()

PATCH New Dan Carpenter 1 participant 1 message Jun 11, 2015

Subsystems (3)

DRM drivers Kernel janitors Radeon and amdgpu DRM drivers

lore

Share & tools

lore

Dan Carpenter

author

2015-06-11 15:13 UTC #0 lore raw

PATCH 1/1 drm/amdgpu: off by one check in dce_v8_0_hpd_irq()

It should be >= instead of > or we go beyond the end of the interrupt_status_offsets[] array. Also I changed it to use ARRAY_SIZE().

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +1 -1

index 9e8b9f1..0f70dc9 100644
@@ -3397,7 +3397,7 @@ static int dce_v8_0_hpd_irq(struct amdgpu_device *adev,
 	uint32_t disp_int, mask, int_control, tmp;
 	unsigned hpd;
 
-	if (entry->src_data > 6) {
+	if (entry->src_data >= ARRAY_SIZE(interrupt_status_offsets)) {
 		DRM_DEBUG("Unhandled interrupt: %d %d\n", entry->src_id, entry->src_data);
 		return 0;
 	}