Skip to contentSkip to conversation

ixgbe: cleanup to use cached mask value

PATCH New Donald C Skidmore 1 participant 1 message Jun 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: cleanup to use cached mask value

From: Don Skidmore <[email protected]>

We already cache this FW/SW semaphore mask so might as well use it for consistency.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c +1 -6
index 526a20b..51ec201 100644
@@ -608,12 +608,7 @@ s32 ixgbe_write_phy_reg_generic(struct ixgbe_hw *hw, u32 reg_addr,
 				u32 device_type, u16 phy_data)
 {
 	s32 status;
-	u32 gssr;
-
-	if (IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1)
-		gssr = IXGBE_GSSR_PHY1_SM;
-	else
-		gssr = IXGBE_GSSR_PHY0_SM;
+	u32 gssr = hw->phy.phy_semaphore_mask;
 
 	if (hw->mac.ops.acquire_swfw_sync(hw, gssr) == 0) {
 		status = ixgbe_write_phy_reg_mdi(hw, reg_addr, device_type,