problem with checkpatch
Hi Joe,
while checking patches I usually check them using mutt pipe to checkpatch. while in mutt, press '|' and then scripts/checkpatch.pl -
and the patch will be checked by checkpatch without having to save it.
Now 700152391c3d ("checkpatch: add --showfile to allow input via pipe to show filenames") is adding $filename ne '-' and because of that if the patch has any
error in Signed-off-by , it is not detecting anymore.
Any solution for this?
regards
sudip
Quoted 8 lines · Sudip Mukherjee
Hi Joe,
while checking patches I usually check them using mutt pipe to checkpatch. while in mutt, press '|' and thenscripts/checkpatch.pl-
and the patch will be checked by checkpatch without having to save it.Now
700152391c3d("checkpatch: add --showfile to allow input via pipe to show filenames") is adding $filename ne '-' and because of that if the patch has any
error in Signed-off-by , it is not detecting anymore.
Any error in signature format should still be found, but a missing sign-off line would not.
Quoted 1 line
Any solution for this?
Modifying checkpatch or using an older version.
Quoted 6 lines · Joe Perches
Quoted 5 lines · Sudip Mukherjee
Hi Joe,
while checking patches I usually check them using mutt pipe to checkpatch. while in mutt, press '|' and thenscripts/checkpatch.pl-
and the patch will be checked by checkpatch without having to save it.
Quoted 6 lines
Quoted 3 lines
Now
700152391c3d("checkpatch: add --showfile to allow input via pipe to show filenames") is adding $filename ne '-' and because of that if the patch has any
error in Signed-off-by , it is not detecting anymore.Any error in signature format should still be found, but a missing sign-off line would not.
yes, the patch with which i noticed this was not having the Signed-off
regards
sudip