Skip to contentSkip to conversation

ACPI / resources: free memory on error in add_region_before()

PATCH Applied Dan Carpenter 2 participants 2 messages Jun 24, 2015

Subsystems (2)
Kernel janitors ACPI
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ACPI / resources: free memory on error in add_region_before()

There is a small memory leak on error.

Signed-off-by Dan Carpenter <[email protected]>
drivers/acpi/resource.c +3 -1
index fcb7807..10561ce 100644
@@ -660,8 +660,10 @@ static int add_region_before(u64 start, u64 end, u8 space_id,
 		return -ENOMEM;
 
 	error = request_range(start, end, space_id, flags, desc);
-	if (error)
+	if (error) {
+		kfree(reg);
 		return error;
+	}
 
 	reg->start = start;
 	reg->end = end;
Applied
#1 lore raw
Quoted 3 lines · Dan Carpenter

There is a small memory leak on error.

Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks!

Quoted 16 lines
drivers/acpi/resource.c +3 -1
index fcb7807..10561ce 100644
@@ -660,8 +660,10 @@ static int add_region_before(u64 start, u64 end, u8 space_id,
 		return -ENOMEM;
 
 	error = request_range(start, end, space_id, flags, desc);
-	if (error)
+	if (error) {
+		kfree(reg);
 		return error;
+	}
 
 	reg->start = start;
 	reg->end = end;
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.