mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()

PATCH In review Aristeu Rozanski 5 participants 5 messages Jul 1, 2015 – Jul 9, 2015

Subsystems (2)

Memory management MM NUMA placement

lore

Share & tools

lore

Aristeu Rozanski

author

2015-07-01 18:31 UTC #0 lore raw

PATCH 1/1 mempolicy: get rid of duplicated check for vma(VM_PFNMAP) in queue_pages_range()

This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()

Cc Naoya Horiguchi <[email protected]>

Cc "Kirill A. Shutemov" <[email protected]>

Cc Andrea Arcangeli <[email protected]>

Cc Cyrill Gorcunov <[email protected]>

Cc Dave Hansen <[email protected]>

Cc Kirill A. Shutemov <[email protected]>

Cc Pavel Emelyanov <[email protected]>

Cc Benjamin Herrenschmidt <[email protected]>

Signed-off-by Aristeu Rozanski <[email protected]>

mm/mempolicy.c +0 -3

index 99d4c1d..9885d07 100644
@@ -608,9 +608,6 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
 
 	qp->prev = vma;
 
-	if (vma->vm_flags & VM_PFNMAP)
-		return 1;
-
 	if (flags & MPOL_MF_LAZY) {
 		/* Similar to task_numa_work, skip inaccessible VMAs */
 		if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Kirill A. Shutemov

Acked-by on v1 1/1

2015-07-01 18:45 UTC #1 lore raw

Quoted 6 lines · Aristeu Rozanski

This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()

Quoted 9 lines

Cc Naoya Horiguchi <[email protected]>
Cc "Kirill A. Shutemov" <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Cc Pavel Emelyanov <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Aristeu Rozanski <[email protected]>

Acked-by Kirill A. Shutemov <[email protected]>

Signature · 7 lines

 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Cyrill Gorcunov

Acked-by on v1 1/1

2015-07-01 20:15 UTC #2 lore raw

In reply to Aristeu Rozanski

Quoted 6 lines · Aristeu Rozanski

This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()

Quoted 9 lines

Cc Naoya Horiguchi <[email protected]>
Cc "Kirill A. Shutemov" <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Cc Pavel Emelyanov <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Aristeu Rozanski <[email protected]>

Acked-by Cyrill Gorcunov <[email protected]>

Thank you!

Naoya Horiguchi

Acked-by on v1 1/1

2015-07-01 23:19 UTC #3 lore raw

In reply to Aristeu Rozanski

Quoted 6 lines · Aristeu Rozanski

This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()

Quoted 9 lines

Cc Naoya Horiguchi <[email protected]>
Cc "Kirill A. Shutemov" <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Cc Pavel Emelyanov <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Aristeu Rozanski <[email protected]>

Thank you for finding and fixing this.

Acked-by Naoya Horiguchi <[email protected]>

Quoted 6 lines

mm/mempolicy.c +0 -0
index 99d4c1d..9885d07 100644

mm/mempolicy.c static int queue_pages_test_walk(unsigned long start, unsigned long end, · line 613

Quoted 9 lines

mm/mempolicy.c +0 -3

@@ -608,9 +608,6 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
 
 	qp->prev = vma;
 
-	if (vma->vm_flags & VM_PFNMAP)
-		return 1;
-
 	if (flags & MPOL_MF_LAZY) {
 		/* Similar to task_numa_work, skip inaccessible VMAs */
 		if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))

David Rientjes

Acked-by on v1 1/1

2015-07-09 00:58 UTC #4 lore raw

In reply to Aristeu Rozanski

Quoted 6 lines · Aristeu Rozanski

This check was introduced as part of
6f4576e3687 - mempolicy: apply page table walker on queue_pages_range()
which got duplicated by
48684a65b4e - mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)
by reintroducing it earlier on queue_page_test_walk()

Quoted 9 lines

Cc Naoya Horiguchi <[email protected]>
Cc "Kirill A. Shutemov" <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Cc Pavel Emelyanov <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Aristeu Rozanski <[email protected]>

Acked-by David Rientjes <[email protected]>