Skip to contentSkip to conversation

config PROC_CHILDREN

DISCUSSION Jean Delvare 4 participants 8 messages Jul 3, 2015 – Jul 8, 2015

lore
Share & tools
lore
#0 lore raw

Hi Iago,

You just introduced a Linux kernel configuration option named PROC_CHILDREN. It is user-visible but has no help. This is bad.

As this option appears to be selected automatically as needed, I'm not sure why you made it visible?

Please either hide the option, or add a help text to let the user make a sane decision.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps that's not clear for the user because as you say the Kconfig help text is missing.

I suggest adding something like:

Provides a fast way to retrieve first level children pids of a task. See <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Thanks.

[1]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt

Quoted 13 lines · Jean Delvare

Hi Iago,

You just introduced a Linux kernel configuration option named PROC_CHILDREN. It is user-visible but has no help. This is bad.

As this option appears to be selected automatically as needed, I'm not sure why you made it visible?

Please either hide the option, or add a help text to let the user make a sane decision.

Thanks,

Signature · 3 lines
Iago López Galeiras
Software developer @ Endocode AG
[email protected]
#2 lore raw

Hi Iago,

Please don't top-post.

Quoted 8 lines · Iago López Galeiras

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps that's not clear for the user because as you say the Kconfig help text is missing.

Quoted 6 lines

I suggest adding something like:

Provides a fast way to retrieve first level children pids of a task. See <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

That's a start, the reference to Documentation/filesystems/proc.txt is good but I think we can do better. You need to help the user make the decision. Why should he/she say Y or N? The user should NOT have to look at an external documentation file if the answer is N. I would suggest the following:

Say Y if running any user-space software which takes benefit from this interface. For example, rkt is such a piece of software.

That being said, I am curious... Is this interface so expensive that it really deserves a separate option, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.)

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#3 lore raw
Quoted 20 lines · Jean Delvare

Hi Iago,

Please don't top-post.

Quoted 8 lines · Iago López Galeiras

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps that's not clear for the user because as you say the Kconfig help text is missing.

Quoted 6 lines

I suggest adding something like:

Provides a fast way to retrieve first level children pids of a task. See <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Quoted 8 lines

That's a start, the reference to Documentation/filesystems/proc.txt is good but I think we can do better. You need to help the user make the decision. Why should he/she say Y or N? The user should NOT have to look at an external documentation file if the answer is N. I would suggest the following:

Say Y if running any user-space software which takes benefit from this interface. For example, rkt is such a piece of software.

That makes it more clear for the user. Thanks!

Quoted 4 lines

That being said, I am curious... Is this interface so expensive that it really deserves a separate option, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.)

I don't think I have enough information to answer that question. I'll CC Cyrill Gorcunov and Andrew Morton.

Signature · 3 lines
Iago López Galeiras
Software developer @ Endocode AG
[email protected]
#4 lore raw

On Wed, Jul 08, 2015 at 04:18:28PM +0200, Iago López Galeiras wrote:
...

Quoted 8 lines
Quoted 5 lines

That being said, I am curious... Is this interface so expensive that it really deserves a separate option, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.)

I don't think I have enough information to answer that question. I'll CC Cyrill Gorcunov and Andrew Morton.

The interface is not expensive per-se but it was developed for checkpoint/restore in first place so we've been wrapping any new code created for this sake with CONFIG_. And we (criu team) were the only users of this interface at those days so it had lot of sence to keep it conditionally enabled.

#5 lore raw
In reply to Iago López Galeiras
Quoted 32 lines · Iago López Galeiras
Quoted 20 lines · Jean Delvare

Hi Iago,

Please don't top-post.

Quoted 8 lines · Iago López Galeiras

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps that's not clear for the user because as you say the Kconfig help text is missing.

Quoted 6 lines

I suggest adding something like:

Provides a fast way to retrieve first level children pids of a task. See <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Quoted 8 lines

That's a start, the reference to Documentation/filesystems/proc.txt is good but I think we can do better. You need to help the user make the decision. Why should he/she say Y or N? The user should NOT have to look at an external documentation file if the answer is N. I would suggest the following:

Say Y if running any user-space software which takes benefit from this interface. For example, rkt is such a piece of software.

That makes it more clear for the user. Thanks!

Quoted 7 lines
Quoted 4 lines

That being said, I am curious... Is this interface so expensive that it really deserves a separate option, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.)

I don't think I have enough information to answer that question. I'll CC Cyrill Gorcunov and Andrew Morton.

IIRC, this was suggested by Andrew Morton, and it results on this patch.

http://www.spinics.net/lists/linux-fsdevel/msg86491.html

Quoted 5 lines
Signature · 3 lines
Iago López Galeiras
Software developer @ Endocode AG
[email protected]
Signature · 2 lines
Djalal Harouni
http://opendz.org
#6 lore raw
Quoted 7 lines · Djalal Harouni
Quoted 6 lines · Iago López Galeiras
Quoted 4 lines · Jean Delvare

That being said, I am curious... Is this interface so expensive that it really deserves a separate option, instead of always enabling it? This seems to be a fairly generic feature that a lot of scripts and tools could benefit from (starting with pstree I suppose.)

Quoted 5 lines
Quoted 2 lines

I don't think I have enough information to answer that question. I'll CC Cyrill Gorcunov and Andrew Morton.

IIRC, this was suggested by Andrew Morton, and it results on this patch.

http://www.spinics.net/lists/linux-fsdevel/msg86491.html

OK, if Andrew said so... :-D

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#7 lore raw
In reply to Iago López Galeiras
Quoted 21 lines · Iago López Galeiras
Quoted 20 lines · Jean Delvare
Quoted 6 lines · Iago López Galeiras

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps that's not clear for the user because as you say the Kconfig help text is missing.

Quoted 6 lines

I suggest adding something like:

Provides a fast way to retrieve first level children pids of a task. See <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

That's a start, the reference to Documentation/filesystems/proc.txt is good but I think we can do better. You need to help the user make the decision. Why should he/she say Y or N? The user should NOT have to look at an external documentation file if the answer is N. I would suggest the following:

Quoted 4 lines
Quoted 2 lines

Say Y if running any user-space software which takes benefit from this interface. For example, rkt is such a piece of software.

That makes it more clear for the user. Thanks!

You're welcome. Will you submit a patch, or should I take care of it?

Signature · 2 lines
Jean Delvare
SUSE L3 Support