Skip to contentSkip to conversation

VDSO build failure: collect2: fatal error: cannot find 'ld'

DISCUSSION Baruch Siach 2 participants 3 messages Jul 6, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

Hi Nathan,

In commit log d2b30cd4b722 (ARM: 8384/1: VDSO: force use of BFD linker, 2015-06-03) you said:

Note: one limitation of this is that if the toolchain is configured to use gold by default, and the bfd linker is not in $PATH, the VDSO build will fail:

VDSO arch/arm/vdso/vdso.so.raw
collect2: fatal error: cannot find 'ld'

This will happen if CROSS_COMPILE begins with a path such as /opt/bin/arm-linux-gnu- but /opt/bin is not in $PATH. This is considered an acceptable corner-case limitation and is easily worked around.

I see this build failure here with Sourcery CodeBench Lite 2014.05 even though:

1. This toolchain doesn't include the gold linker at all

2. I have the arm-2014.05/bin/ directory in my $PATH

3. My CROSS_COMPILE is set to 'arm-none-linux-gnueabi-'

Reverting d2b30cd4b722 on v4.2-rc1 fixes the build failure.

The Sourcery CodeBench Lite 2014.05 (gcc: 4.8.3, binutils: 2.24.51) is available at
http://sourcery.mentor.com/public/gnu_toolchain/arm-none-linux-gnueabi/arm-2014.05-29-arm-none-linux-gnueabi-i686-pc-linux-gnu.tar.bz2

Any hint?

Thanks,
baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#1 lore raw
Quoted 18 lines · Baruch Siach

In commit log d2b30cd4b722 (ARM: 8384/1: VDSO: force use of BFD linker, 2015-06-03) you said:

Note: one limitation of this is that if the toolchain is configured to use gold by default, and the bfd linker is not in $PATH, the VDSO build will fail:

VDSO arch/arm/vdso/vdso.so.raw
collect2: fatal error: cannot find 'ld'

This will happen if CROSS_COMPILE begins with a path such as /opt/bin/arm-linux-gnu- but /opt/bin is not in $PATH. This is considered an acceptable corner-case limitation and is easily worked around.

I see this build failure here with Sourcery CodeBench Lite 2014.05 even though:

Quoted 7 lines

1. This toolchain doesn't include the gold linker at all

2. I have the arm-2014.05/bin/ directory in my $PATH

3. My CROSS_COMPILE is set to 'arm-none-linux-gnueabi-'

Reverting d2b30cd4b722 on v4.2-rc1 fixes the build failure.

Thanks for the detailed report; I have been able to recreate this.

This seems to be happening because the compiler supports -fuse-ld=bfd, but the toolchain does not contain a "arm-none-linux-gnueabi-ld.bfd"
executable: creating a symlink arm-none-linux-gnueabi-ld.bfd => arm-none-linux-gnueabi-ld in arm-2014.05/bin/ allows the build to succeed.

I'm not sure whether this is a toolchain bug or incorrect expectations on my part, but I'm not eager to break a toolchain that used to work. I think the least bad resolution is to use cc-ldoption for detecting whether -fuse-ld=bfd will work. The tradeoff is that if the vdso link is attempted with gold we'll get a marginally less user-friendly error message.

Baruch, can you confirm the patch below fixes it for you?

arch/arm/vdso/Makefile +1 -2
index 9d259d94e429..1160434eece0 100644
@@ -14,7 +14,7 @@ VDSO_LDFLAGS += -Wl,-z,max-page-size=4096
-Wl,-z,common-page-size=4096
 VDSO_LDFLAGS += -nostdlib -shared
 VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
 VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id)
-VDSO_LDFLAGS += $(call cc-option, -fuse-ld=bfd)
+VDSO_LDFLAGS += $(call cc-ldoption, -fuse-ld=bfd)
 
 obj-$(CONFIG_VDSO) += vdso.o

extra-$(CONFIG_VDSO) += vdso.lds

author Tested-by
#2 lore raw

Hi Nathan,

Quoted 10 lines · Nathan Lynch
Quoted 1 line · Baruch Siach

Reverting d2b30cd4b722 on v4.2-rc1 fixes the build failure.

Baruch, can you confirm the patch below fixes it for you?

arch/arm/vdso/Makefile +0 -0
index 9d259d94e429..1160434eece0 100644

arch/arm/vdso/Makefile VDSO_LDFLAGS += -Wl,-z,max-page-size=4096

Quoted 9 lines
arch/arm/vdso/Makefile +1 -2
@@ -14,7 +14,7 @@ VDSO_LDFLAGS += -Wl,-z,max-page-size=4096
-Wl,-z,common-page-size=4096
 VDSO_LDFLAGS += -nostdlib -shared
 VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
 VDSO_LDFLAGS += $(call cc-ldoption, -Wl$(comma)--build-id)
-VDSO_LDFLAGS += $(call cc-option, -fuse-ld=bfd)
+VDSO_LDFLAGS += $(call cc-ldoption, -fuse-ld=bfd)
 
 obj-$(CONFIG_VDSO) += vdso.o
 extra-$(CONFIG_VDSO) += vdso.lds

With this patch applied kernel build using the Sourcery CodeBench Lite 2014.05 toolchain succeeds.

Thanks for your prompt response.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -